From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH -mm] remove node_ prefix_from ns subsystem Date: Thu, 22 May 2008 00:32:13 -0700 Message-ID: <20080522003213.d677ba30.akpm@linux-foundation.org> References: <48344409.9090903@fr.ibm.com> <20080521220657.12e8e8c9.akpm@linux-foundation.org> <6599ad830805220011u77313ed7s2c0c9d4a658133cc@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6599ad830805220011u77313ed7s2c0c9d4a658133cc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: Linux Containers , Cedric Le Goater , Linux Kernel Mailing List List-Id: containers.vger.kernel.org On Thu, 22 May 2008 00:11:56 -0700 "Paul Menage" wrote: > On Wed, May 21, 2008 at 10:06 PM, Andrew Morton > wrote: > >> --- 2.6.26-rc2-mm1.orig/kernel/cgroup.c > >> +++ 2.6.26-rc2-mm1/kernel/cgroup.c > >> @@ -2903,7 +2903,7 @@ int cgroup_clone(struct task_struct *tsk > >> cg = tsk->cgroups; > >> parent = task_cgroup(tsk, subsys->subsys_id); > >> > >> - snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "node_%d", tsk->pid); > >> + snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "%d", tsk->pid); > >> > >> /* Pin the hierarchy */ > >> atomic_inc(&parent->root->sb->s_active); > > > > This is user-visible, isn't it? Been there since October. How can we > > safely change it now? > > It is user-visible, but I'd be extremely surprised if anyone was > depending on it or even using it at this point. After six months? Oh well, I guess the number is small, and they'll know how to fix it. What is the reason for making this change? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933668AbYEVHeI (ORCPT ); Thu, 22 May 2008 03:34:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759636AbYEVHd4 (ORCPT ); Thu, 22 May 2008 03:33:56 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41305 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbYEVHd4 (ORCPT ); Thu, 22 May 2008 03:33:56 -0400 Date: Thu, 22 May 2008 00:32:13 -0700 From: Andrew Morton To: "Paul Menage" Cc: "Cedric Le Goater" , "Serge E. Hallyn" , "Linux Kernel Mailing List" , "Linux Containers" Subject: Re: [PATCH -mm] remove node_ prefix_from ns subsystem Message-Id: <20080522003213.d677ba30.akpm@linux-foundation.org> In-Reply-To: <6599ad830805220011u77313ed7s2c0c9d4a658133cc@mail.gmail.com> References: <48344409.9090903@fr.ibm.com> <20080521220657.12e8e8c9.akpm@linux-foundation.org> <6599ad830805220011u77313ed7s2c0c9d4a658133cc@mail.gmail.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 May 2008 00:11:56 -0700 "Paul Menage" wrote: > On Wed, May 21, 2008 at 10:06 PM, Andrew Morton > wrote: > >> --- 2.6.26-rc2-mm1.orig/kernel/cgroup.c > >> +++ 2.6.26-rc2-mm1/kernel/cgroup.c > >> @@ -2903,7 +2903,7 @@ int cgroup_clone(struct task_struct *tsk > >> cg = tsk->cgroups; > >> parent = task_cgroup(tsk, subsys->subsys_id); > >> > >> - snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "node_%d", tsk->pid); > >> + snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "%d", tsk->pid); > >> > >> /* Pin the hierarchy */ > >> atomic_inc(&parent->root->sb->s_active); > > > > This is user-visible, isn't it? Been there since October. How can we > > safely change it now? > > It is user-visible, but I'd be extremely surprised if anyone was > depending on it or even using it at this point. After six months? Oh well, I guess the number is small, and they'll know how to fix it. What is the reason for making this change?