From: Jens Axboe <jens.axboe@oracle.com>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Move the second call to get_request to the end of the loop
Date: Thu, 22 May 2008 15:10:36 +0200 [thread overview]
Message-ID: <20080522131036.GH7712@kernel.dk> (raw)
In-Reply-To: <1211444984.3177.256.camel@ymzhang>
On Thu, May 22 2008, Zhang, Yanmin wrote:
> In function get_request_wait, the second call to get_request could be
> moved to the end of the while loop, because if the first call to
> get_request fails, the second call will fail without sleep.
Looks safe enough, since we don't drop the lock in between getting the
request and adding to the wait queue. I'll add it to the testing mix,
thanks!
--
Jens Axboe
prev parent reply other threads:[~2008-05-22 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 8:29 [PATCH] Move the second call to get_request to the end of the loop Zhang, Yanmin
2008-05-22 13:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522131036.GH7712@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.