From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: mahalcro@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: BUG: Ecryptfs ioctl handling
Date: Thu, 22 May 2008 13:53:44 +0200 [thread overview]
Message-ID: <200805221353.45239.arnd@arndb.de> (raw)
In-Reply-To: <20080522111746.6c78507b@core>
On Thursday 22 May 2008, Alan Cox wrote:
>
> Ecryptfs has an ioctl method that checks for the underlying fs ioctl
> method and can call down into. Unfortunately however it doesn't check for
> an underlying unlocked_ioctl method and call that if present.
>
> Notices while removing the remaining users of ->ioctl from my dev tree.
>
> Really ecryptfs needs its own ->unlocked_ioctl op to call into either
> unlocked ioctl below or lock_kernel/ioctl/unlock_kernel below.
Similarly, ecryptfs doesn't provide a ->compat_ioctl op that calls into
the file system's ->compat_ioctl operation if present.
This will be needed to make ioctl handling work on file systems that
rely on ->compat_ioctl for 32 bit processes.
I wonder if there are other places in the kernel that just pass down
ioctl calls to a slave file system or driver and need to have this
added.
Arnd <><
prev parent reply other threads:[~2008-05-22 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 10:17 BUG: Ecryptfs ioctl handling Alan Cox
2008-05-22 11:53 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805221353.45239.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mahalcro@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.