All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: initialization of static per-cpu variables
Date: Thu, 22 May 2008 18:20:06 +1000	[thread overview]
Message-ID: <200805221820.07290.rusty@rustcorp.com.au> (raw)
In-Reply-To: <19f34abd0805211128r29fa437fm9e9e4c3d3c196f62@mail.gmail.com>

On Thursday 22 May 2008 04:28:02 Vegard Nossum wrote:
> Hi,
>
> I encountered this comment in kernel/softirq.c:
>
> /* Some compilers disobey section attribute on statics when not
>    initialized -- RR */
> static DEFINE_PER_CPU(struct tasklet_head, tasklet_vec) = { NULL };
> static DEFINE_PER_CPU(struct tasklet_head, tasklet_hi_vec) = { NULL };
>
> So I assume it's the combination of static and whatever section
> DFINE_PER_CPU puts the variable in which is the problem.
>
> However, there's a LOT of these "static DEFINE_PER_CPU" without any
> initializer in the rest of the code, e.g.:

Yep, it was an old toolchain used by Sparc: DaveM found this one.  As you say, 
it's ancient: I'm happy to queue a cleanup patch now everyone is on a modern 
compiler.

Thanks,
Rusty.

  reply	other threads:[~2008-05-22  8:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 18:28 initialization of static per-cpu variables Vegard Nossum
2008-05-22  8:20 ` Rusty Russell [this message]
2008-05-22 16:12   ` David Miller
2008-05-23 14:29   ` Adrian Bunk
2008-05-23 14:43     ` Vegard Nossum
2008-05-25 10:35     ` Rusty Russell
2008-06-02  7:59       ` Adrian Bunk
2008-06-02 23:11         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805221820.07290.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.