From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: linux-kernel@vger.kernel.org, sfr@au1.ibm.com
Subject: [PATCH] viotape: Push down BKL ioctls
Date: Thu, 22 May 2008 22:20:12 +0100 [thread overview]
Message-ID: <20080522222012.3a07bd57@core> (raw)
Signed-off-by: Alan Cox <alan@redhat.com>
diff --git a/drivers/char/viotape.c b/drivers/char/viotape.c
index 58aad63..b75f79f 100644
--- a/drivers/char/viotape.c
+++ b/drivers/char/viotape.c
@@ -46,8 +46,9 @@
#include <linux/completion.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
+#include <linux/smp_lock.h>
+#include <linux/uaccess.h>
-#include <asm/uaccess.h>
#include <asm/ioctls.h>
#include <asm/firmware.h>
#include <asm/vio.h>
@@ -509,18 +510,24 @@ free_op:
}
/* ioctl */
-static int viotap_ioctl(struct inode *inode, struct file *file,
- unsigned int cmd, unsigned long arg)
+static long viotap_ioctl(struct file *file, unsigned int cmd,
+ unsigned long arg)
{
HvLpEvent_Rc hvrc;
int ret;
struct viot_devinfo_struct devi;
struct mtop mtc;
u32 myOp;
- struct op_struct *op = get_op_struct();
+ struct op_struct *op;
- if (op == NULL)
+ lock_kernel();
+
+ op= get_op_struct();
+
+ if (op == NULL) {
+ unlock_kernel();
return -ENOMEM;
+ }
get_dev_info(file->f_path.dentry->d_inode, &devi);
@@ -661,6 +668,7 @@ static int viotap_ioctl(struct inode *inode, struct file *file,
&viomtget[devi.devno],
sizeof(viomtget[0])))
ret = -EFAULT;
+ unlock_kernel();
return ret;
case MTIOCPOS:
printk(VIOTAPE_KERN_WARN "Got an (unsupported) MTIOCPOS\n");
@@ -674,6 +682,7 @@ static int viotap_ioctl(struct inode *inode, struct file *file,
free_op:
free_op_struct(op);
up(&reqSem);
+ unlock_kernel();
return ret;
}
@@ -783,12 +792,12 @@ free_op:
}
const struct file_operations viotap_fops = {
- .owner = THIS_MODULE,
- .read = viotap_read,
- .write = viotap_write,
- .ioctl = viotap_ioctl,
- .open = viotap_open,
- .release = viotap_release,
+ .owner = THIS_MODULE,
+ .read = viotap_read,
+ .write = viotap_write,
+ .unlocked_ioctl = viotap_ioctl,
+ .open = viotap_open,
+ .release = viotap_release,
};
/* Handle interrupt events for tape */
@@ -1000,8 +1009,7 @@ static int chg_state(int index, unsigned char new_state, struct file *file)
if (*cur_state == VIOT_WRITING) {
struct mtop write_eof = { MTWEOF, 1 };
- rc = viotap_ioctl(NULL, file, MTIOCTOP,
- (unsigned long)&write_eof);
+ rc = viotap_ioctl(file, MTIOCTOP, (unsigned long)&write_eof);
}
*cur_state = new_state;
return rc;
next reply other threads:[~2008-05-22 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 21:20 Alan Cox [this message]
2008-05-23 3:04 ` [PATCH] viotape: Push down BKL ioctls Stephen Rothwell
2008-05-23 5:12 ` [PATCH] [POWERPC] viotape: use unlocked_ioctl Stephen Rothwell
2008-05-23 5:12 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522222012.3a07bd57@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.