From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Subject: Re: [patch 05/14] hpfs: dont call permission()
Date: Fri, 23 May 2008 05:20:02 -0400 [thread overview]
Message-ID: <20080523092002.GC27119@infradead.org> (raw)
In-Reply-To: <20080521171548.148636128@szeredi.hu>
On Wed, May 21, 2008 at 07:15:03PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> hpfs_unlink() calls permission() prior to truncating the file. HPFS
> doesn't define a .permission method, so replace with explicit call to
> generic_permission().
>
> This is equivalent, except that devcgroup_inode_permission() and
> security_inode_permission() are not called.
>
> The truncation is just an implementation detail of the unlink, so
> these security checks are unnecessary.
>
> I suspect that even calling generic_permission() is unnecessary, since
> we shouldn't mind if the file isn't writable. But I leave that to the
> maintainer to decide.
Okay to me but rather pointless. And I agree to the last stance that
the whole logic in hpfs_unlink really needs sorting out by someone who
understands that filesystem.
next prev parent reply other threads:[~2008-05-23 9:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 17:14 [patch 00/14] vfs: permission API cleanup Miklos Szeredi
2008-05-21 17:14 ` [patch 01/14] vfs: add path_getxattr() Miklos Szeredi
2008-05-21 17:15 ` [patch 02/14] vfs: add path_listxattr() Miklos Szeredi
2008-05-21 17:15 ` [patch 03/14] hppfs: remove hppfs_permission Miklos Szeredi
2008-05-23 9:17 ` Christoph Hellwig
2008-05-21 17:15 ` [patch 04/14] gfs2: dont call permission() Miklos Szeredi
2008-05-23 9:12 ` Steven Whitehouse
2008-05-23 9:30 ` Miklos Szeredi
2008-05-23 9:32 ` Christoph Hellwig
2008-05-23 9:18 ` Christoph Hellwig
2008-05-23 9:48 ` Miklos Szeredi
2008-05-23 10:00 ` Miklos Szeredi
2008-05-25 19:24 ` Christoph Hellwig
2008-05-23 10:18 ` Steven Whitehouse
2008-05-23 11:01 ` Miklos Szeredi
2008-05-25 19:23 ` Christoph Hellwig
2008-05-21 17:15 ` [patch 05/14] hpfs: " Miklos Szeredi
2008-05-23 9:20 ` Christoph Hellwig [this message]
2008-05-21 17:15 ` [patch 06/14] hfsplus: remove hfsplus_permission() Miklos Szeredi
2008-05-21 20:35 ` Roman Zippel
2008-05-22 7:58 ` Miklos Szeredi
2008-05-22 12:02 ` Roman Zippel
2008-05-22 12:17 ` Miklos Szeredi
2008-05-22 12:28 ` Roman Zippel
2008-05-22 12:37 ` Miklos Szeredi
2008-05-23 9:21 ` Christoph Hellwig
2008-05-23 15:18 ` Roman Zippel
2008-05-23 15:31 ` Miklos Szeredi
2008-05-23 15:49 ` Miklos Szeredi
2008-05-23 16:30 ` Roman Zippel
2008-05-23 18:02 ` Miklos Szeredi
2008-05-23 18:33 ` Roman Zippel
2008-05-23 19:05 ` Miklos Szeredi
2008-05-23 21:52 ` Roman Zippel
2008-05-24 6:59 ` Miklos Szeredi
2008-05-23 15:11 ` Roman Zippel
2008-05-21 17:15 ` [patch 07/14] vfs: pass dentry to permission() Miklos Szeredi
2008-05-21 20:29 ` Al Viro
2008-05-22 7:00 ` Miklos Szeredi
2008-05-22 7:12 ` Miklos Szeredi
2008-05-21 17:15 ` [patch 08/14] vfs: cleanup i_op->permission() Miklos Szeredi
2008-05-21 17:15 ` [patch 09/14] security: dont pass nameidata to security_inode_permission() Miklos Szeredi
2008-05-21 22:52 ` James Morris
2008-05-21 17:15 ` [patch 10/14] vfs: pass flags to dentry_permission() Miklos Szeredi
2008-05-21 17:15 ` [patch 11/14] vfs: move executable checking into ->permission() Miklos Szeredi
2008-05-21 18:16 ` Trond Myklebust
2008-05-21 19:09 ` Miklos Szeredi
2008-05-21 19:26 ` Trond Myklebust
2008-05-21 19:34 ` Miklos Szeredi
2008-05-23 9:26 ` Christoph Hellwig
2008-05-23 9:52 ` Miklos Szeredi
2008-05-21 17:15 ` [patch 12/14] vfs: create path_permission() Miklos Szeredi
2008-05-21 17:15 ` [patch 13/14] vfs: dont use dentry_permission() Miklos Szeredi
2008-05-21 17:15 ` [patch 14/14] vfs: path_permission() clean up flags Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523092002.GC27119@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.