From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Switch apm to unlocked_kernel
Date: Fri, 23 May 2008 12:06:17 +0100 [thread overview]
Message-ID: <20080523120617.6a4c115c@core> (raw)
In-Reply-To: <20080523110353.7a1360b5.sfr@canb.auug.org.au>
On Fri, 23 May 2008 11:03:53 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Alan,
>
> On Thu, 22 May 2008 21:22:04 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >
> > This pushes the lock a fair way down and the final kill looks like it
> > should be an easy project for someone who wants to have a shot at it.
>
> and makes some gratuitous stylistic changes as well. Please don't do
> that!
Andrew shouts at me if I send him patches that don't fix the style of
the lines around so you get some style changes even when I cut bits out
of diffs. I think that approach is *stupid* too and style should be done
after for the entire file.
Alan
next prev parent reply other threads:[~2008-05-23 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 20:22 [PATCH] x86: Switch apm to unlocked_kernel Alan Cox
2008-05-23 1:03 ` Stephen Rothwell
2008-05-23 11:06 ` Alan Cox [this message]
2008-05-23 13:23 ` Stephen Rothwell
2008-05-23 17:25 ` Andrew Morton
2008-05-23 11:36 ` Kevin Winchester
2008-05-24 18:59 ` [RFC] " Kevin Winchester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523120617.6a4c115c@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.