From: Ivo van Doorn <ivdoorn@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: [PATCH 1/4] rt2x00: Fix memleak in tx() path
Date: Fri, 23 May 2008 18:13:41 +0200 [thread overview]
Message-ID: <200805231813.41562.IvDoorn@gmail.com> (raw)
In-Reply-To: <200805231811.38557.IvDoorn@gmail.com>
When the tx() handler runs while the device has disapeared,
we did return NETDEV_TX_OK but didn't free the skb.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
drivers/net/wireless/rt2x00/rt2x00mac.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
index 2333b53..d068ea9 100644
--- a/drivers/net/wireless/rt2x00/rt2x00mac.c
+++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
@@ -114,6 +114,7 @@ int rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
*/
if (!test_bit(DEVICE_PRESENT, &rt2x00dev->flags)) {
ieee80211_stop_queues(hw);
+ dev_kfree_skb_any(skb);
return NETDEV_TX_OK;
}
--
1.5.5.1
next parent reply other threads:[~2008-05-23 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200805231811.38557.IvDoorn@gmail.com>
2008-05-23 16:13 ` Ivo van Doorn [this message]
[not found] ` <200805231812.00201.IvDoorn@gmail.com>
2008-05-23 16:13 ` [PATCH 2/4] rt2x00: Don't count retries as failure Ivo van Doorn
[not found] ` <200805231812.18092.IvDoorn@gmail.com>
2008-05-23 16:13 ` [PATCH 3/4] rt2x00: Reset antenna RSSI after switch Ivo van Doorn
[not found] ` <200805231812.43582.IvDoorn@gmail.com>
2008-05-23 16:14 ` [PATCH 4/4] rt2x00: Use atomic interface iteration in irq context Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805231813.41562.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.