From: Clemens Buchacher <drizzd@aon.at>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junio@pobox.com>, git@vger.kernel.org
Subject: [PATCH] lockfile: reset the correct signal
Date: Mon, 26 May 2008 21:35:13 +0200 [thread overview]
Message-ID: <20080526193513.GA9978@localhost> (raw)
In-Reply-To: <alpine.DEB.1.00.0805261031480.30431@racer>
In the function remove_lock_file_on_signal(), the signal handler
for SIGINT was reset, ignoring the parameter signo.
This did not pose a problem yet, as remove_lock_file_on_signal()
was only registered as a SIGINT handler.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
On Mon, May 26, 2008 at 10:34:11AM +0100, Johannes Schindelin wrote:
> Only from the patch did I understand that you actually meant:
Thank you for fixing that.
I also realized that using signals like that can cause races. Shouldn't we
use sigaction() instead of signal()?
Clemens
---
lockfile.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lockfile.c b/lockfile.c
index 663f18f..b0118d0 100644
--- a/lockfile.c
+++ b/lockfile.c
@@ -24,7 +24,7 @@ static void remove_lock_file(void)
static void remove_lock_file_on_signal(int signo)
{
remove_lock_file();
- signal(SIGINT, SIG_DFL);
+ signal(signo, SIG_DFL);
raise(signo);
}
--
1.5.5.1
next prev parent reply other threads:[~2008-05-26 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 19:55 [PATCH] http-push: remove remote locks on exit signals Clemens Buchacher
2008-05-23 21:40 ` Junio C Hamano
2008-05-23 22:17 ` Clemens Buchacher
2008-05-25 18:26 ` [PATCH] Reset the signal being handled Clemens Buchacher
2008-05-26 9:34 ` Johannes Schindelin
2008-05-26 19:35 ` Clemens Buchacher [this message]
2008-05-26 21:36 ` [PATCH] lockfile: reset the correct signal Johannes Schindelin
2008-05-27 7:49 ` Clemens Buchacher
2008-05-25 18:27 ` [PATCH] http-push: remove remote locks on exit signals Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526193513.GA9978@localhost \
--to=drizzd@aon.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.