From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Timur Tabi <timur@freescale.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SERIAL] fix driver_name conflicts
Date: Mon, 26 May 2008 21:02:07 +0100 [thread overview]
Message-ID: <20080526210207.5730e9cc@core> (raw)
In-Reply-To: <20080526172340.GA17703@polina.dev.rtsoft.ru>
On Mon, 26 May 2008 21:23:40 +0400
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> Some drivers are using too generic "serial" name for driver_name, this
> might cause issues, like this:
>
> Freescale QUICC Engine UART device driver
> proc_dir_entry 'serial' already registered
> Call Trace:
> [cf82de50] [c0007f7c] show_stack+0x4c/0x1ac (unreliable)
> [cf82de90] [c00b03fc] proc_register+0xfc/0x1ac
> [cf82dec0] [c00b05c8] create_proc_entry+0x60/0xac
> [cf82dee0] [c00b23dc] proc_tty_register_driver+0x60/0x98
> [cf82def0] [c016dbd8] tty_register_driver+0x1b4/0x228
> [cf82df20] [c0184d70] uart_register_driver+0x144/0x194
> [cf82df40] [c030a378] ucc_uart_init+0x2c/0x94
> [cf82df50] [c02f21a0] kernel_init+0x98/0x27c
> [cf82dff0] [c000fa74] kernel_thread+0x44/0x60
>
> ^^ The board is using ucc_uart.c and 8250.c, both registered as
> "serial".
>
> This patch fixes two drivers that are using "serial" for driver_name and
> not "ttyS" for dev_name. Drivers that are using "ttyS" for dev_name, will
> conflict anyway, so we don't bother with these.
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-05-26 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 17:23 [PATCH] [SERIAL] fix driver_name conflicts Anton Vorontsov
2008-05-26 20:02 ` Alan Cox [this message]
2008-05-27 14:43 ` Timur Tabi
2008-05-28 14:15 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526210207.5730e9cc@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.