Re: race in skb_splice_bits?

[Ben Hutchings <bhutchings@solarflare.com>]

Octavian Purdila wrote:
> 
> Hi,
> 
> The following socket lock dropping in skb_splice_bits seems to open a race 
> condition which causes an invalid kernel access:
> 
> >        if (spd.nr_pages) {
> >                int ret;
> >
> >                /*
> >                 * Drop the socket lock, otherwise we have reverse
> >                 * locking dependencies between sk_lock and i_mutex
> >                 * here as compared to sendfile(). We enter here
> >                 * with the socket lock held, and splice_to_pipe() will
> >                 * grab the pipe inode lock. For sendfile() emulation,
> >                 * we call into ->sendpage() with the i_mutex lock held
> >                 * and networking will grab the socket lock.
> >                 */
> >                release_sock(__skb->sk);
> >                ret = splice_to_pipe(pipe, &spd);
> >                lock_sock(__skb->sk);
> >                return ret;
> >        }

Given the previous comment, that certainly looks wrong.

<snip>
> Commenting out the sequence that drops the socket lock seems to fix the
> problem on my setup.

But this could apparently cause deadlock.  Surely the correct fix is
to copy __skb->sk to a local variable before calling splice_to_pipe()
so we can re-lock it?

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.