From: Greg KH <greg@kroah.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: usb/sparc build failure
Date: Tue, 27 May 2008 11:02:36 -0700 [thread overview]
Message-ID: <20080527180236.GA23505@kroah.com> (raw)
In-Reply-To: <483C47D3.2090705@csr.com>
On Tue, May 27, 2008 at 06:41:39PM +0100, David Vrabel wrote:
> Stephen Rothwell wrote:
> > Hi Greg,
> >
> > Today's (though it is not new) linux-next build (spac allmodconfig) fails
> > like this:
> >
> > drivers/uwb/whci.c:166: error: `DMA_64BIT_MASK' undeclared (first use in this function)
> > drivers/uwb/whci.c:166: error: (Each undeclared identifier is reported only once
> > drivers/uwb/whci.c:166: error: for each function it appears in.)
> > drivers/uwb/whci.c:168: error: `DMA_32BIT_MASK' undeclared (first use in this function)
> > drivers/uwb/whc-rc.c:268: error: implicit declaration of function `dma_alloc_coherent'
> > drivers/uwb/whc-rc.c:286: error: implicit declaration of function `dma_free_coherent'
> > drivers/usb/host/whci/pzl.c:372: error: implicit declaration of function `dma_alloc_coherent'
> > drivers/usb/host/whci/pzl.c:395: error: implicit declaration of function `dma_free_coherent'
> > drivers/usb/host/whci/init.c:132: error: implicit declaration of function `dma_alloc_coherent'
> > drivers/usb/host/whci/init.c:162: error: implicit declaration of function `dma_free_coherent'
> > drivers/usb/host/whci/hw.c:48: error: implicit declaration of function `dma_map_single'
> > drivers/usb/host/whci/hw.c:48: error: `DMA_TO_DEVICE' undeclared (first use in this function)
> > drivers/usb/host/whci/hw.c:48: error: (Each undeclared identifier is reported only once
> > drivers/usb/host/whci/hw.c:48: error: for each function it appears in.)
> > drivers/usb/host/whci/hw.c:78: error: implicit declaration of function `dma_unmap_single'
> > drivers/usb/host/whci/qset.c:274: error: implicit declaration of function `dma_unmap_single'
> > drivers/usb/host/whci/qset.c:276: error: `DMA_TO_DEVICE' undeclared (first use in this function)
> > drivers/usb/host/whci/qset.c:276: error: (Each undeclared identifier is reported only once
> > drivers/usb/host/whci/qset.c:276: error: for each function it appears in.)
> > drivers/usb/host/whci/qset.c:326: error: implicit declaration of function `dma_map_single'
> > drivers/usb/host/whci/qset.c:326: error: `DMA_TO_DEVICE' undeclared (first use in this function)
> >
> > I suspect that these files should include linux/dma-mapping.h directly
> > since it uses things from there.
>
> How odd. Looking at my local patch set this has been fixed but looking
> at the patches Greg has and I see it's not. Try this.
>
> I also note that some architectures (sparc amongst them) will BUG with
> these drivers as the DMA API is only available to PCI devices. The
> whc-rc and whci-hcd drivers use umc devices which are children of a PCI
> device.
Thanks, I've now merged this in with my patch series.
greg k-h
next prev parent reply other threads:[~2008-05-27 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 10:26 linux-next: usb/sparc build failure Stephen Rothwell
2008-05-27 16:50 ` Greg KH
2008-05-27 23:19 ` Stephen Rothwell
2008-05-27 17:41 ` David Vrabel
2008-05-27 18:02 ` Greg KH [this message]
2008-05-27 23:25 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527180236.GA23505@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@csr.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.