From: Tony Lindgren <tony@atomide.com>
To: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Add SDTI device for OMAP3 and unify address definitions for OMAP1 and OMAP2.
Date: Wed, 28 May 2008 13:33:23 -0700 [thread overview]
Message-ID: <20080528203323.GH8845@atomide.com> (raw)
In-Reply-To: <1211990758-4252-1-git-send-email-roman.tereshonkov@nokia.com>
Thanks, pushing today.
Tony
* Roman Tereshonkov <roman.tereshonkov@nokia.com> [080528 09:08]:
>
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
> ---
> arch/arm/mach-omap1/devices.c | 2 +-
> arch/arm/mach-omap2/devices.c | 23 ++++++++++++++++++++++-
> drivers/misc/sti/sti.c | 4 ++--
> 3 files changed, 25 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
> index da8a3ac..15ab43c 100644
> --- a/arch/arm/mach-omap1/devices.c
> +++ b/arch/arm/mach-omap1/devices.c
> @@ -102,7 +102,7 @@ static inline void omap_init_mbox(void) { }
>
> #if defined(CONFIG_OMAP_STI)
>
> -#define OMAP1_STI_BASE IO_ADDRESS(0xfffea000)
> +#define OMAP1_STI_BASE 0xfffea000
> #define OMAP1_STI_CHANNEL_BASE (OMAP1_STI_BASE + 0x400)
>
> static struct resource sti_resources[] = {
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index d02e9e5..d8fb3f8 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -92,7 +92,9 @@ static inline void omap_init_mbox(void) { }
>
> #if defined(CONFIG_OMAP_STI)
>
> -#define OMAP2_STI_BASE IO_ADDRESS(0x48068000)
> +#if defined(CONFIG_ARCH_OMAP2)
> +
> +#define OMAP2_STI_BASE 0x48068000
> #define OMAP2_STI_CHANNEL_BASE 0x54000000
> #define OMAP2_STI_IRQ 4
>
> @@ -112,6 +114,25 @@ static struct resource sti_resources[] = {
> .flags = IORESOURCE_IRQ,
> }
> };
> +#elif defined(CONFIG_ARCH_OMAP3)
> +
> +#define OMAP3_SDTI_BASE 0x54500000
> +#define OMAP3_SDTI_CHANNEL_BASE 0x54600000
> +
> +static struct resource sti_resources[] = {
> + {
> + .start = OMAP3_SDTI_BASE,
> + .end = OMAP3_SDTI_BASE + 0xFFF,
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + .start = OMAP3_SDTI_CHANNEL_BASE,
> + .end = OMAP3_SDTI_CHANNEL_BASE + SZ_1M - 1,
> + .flags = IORESOURCE_MEM,
> + }
> +};
> +
> +#endif
>
> static struct platform_device sti_device = {
> .name = "sti",
> diff --git a/drivers/misc/sti/sti.c b/drivers/misc/sti/sti.c
> index e828860..1140fed 100644
> --- a/drivers/misc/sti/sti.c
> +++ b/drivers/misc/sti/sti.c
> @@ -356,7 +356,7 @@ static int __devinit sti_probe(struct platform_device *pdev)
> if (unlikely(ret != 0))
> goto err;
>
> - sti_base = res->start;
> + sti_base = io_p2v(res->start);
>
> /*
> * OMAP 16xx keeps channels in a relatively sane location,
> @@ -364,7 +364,7 @@ static int __devinit sti_probe(struct platform_device *pdev)
> * remapped.
> */
> if (cpu_is_omap16xx())
> - sti_channel_base = cres->start;
> + sti_channel_base = io_p2v(cres->start);
> else if (cpu_is_omap24xx()) {
> unsigned int size = cres->end - cres->start;
>
> --
> 1.5.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-28 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 16:05 [PATCH] Add SDTI device for OMAP3 and unify address definitions for OMAP1 and OMAP2 Roman Tereshonkov
2008-05-28 20:33 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528203323.GH8845@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.