All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Högander Jouni" <jouni.hogander@nokia.com>
Cc: ext Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	Richard Woodruff <r-woodruff2@ti.com>
Subject: Re: [PATCH 0/2] Add D2D clockdomain on OMAP3 ES2+
Date: Wed, 28 May 2008 13:42:16 -0700	[thread overview]
Message-ID: <20080528204216.GK8845@atomide.com> (raw)
In-Reply-To: <87wsllmt6q.fsf@trdhcp146196.ntc.nokia.com>

* Högander Jouni <jouni.hogander@nokia.com> [080522 23:27]:
> "ext Paul Walmsley" <paul@pwsan.com> writes:
> 
> > Hello,
> >
> > This patch series adds D2D (die-to-die) clockdomain handling into
> > OMAP3 ES2+ builds.  It seems the D2D clockdomain logic is still
> > present on the chip and must be manually programmed to allow the
> > CORE_D2D clockdomain to go inactive.
> >
> > For this to work, the pm34xx.c code also had to be modified to use the
> > pwrdm_for_each_clkdm() iterator, lest the existing for-loop fall off
> > the end of pwrdm->pwrdm_clkdms[].  This also should fix an oops with
> > CONFIG_PM on any 3430ES1 boards out there.
> 
> That loop was a good catch, thanks.
> 
> Both patches acked.

Pushing both today.

Tony

> 
> >
> > Tested on 3430SDP ES2.0.
> >
> >
> > - Paul
> >
> >
> > diffstat:
> >  arch/arm/mach-omap2/clockdomains.h |    9 ++++++++-
> >  arch/arm/mach-omap2/pm34xx.c       |   23 ++++++++++++++++++-----
> >  2 files changed, 26 insertions(+), 6 deletions(-)
> >
> > size:
> >    text    data     bss     dec     hex filename
> > 3280225  155416   98792 3534433  35ee61 vmlinux.3430sdp.orig
> > 3280305  155416   98792 3534513  35eeb1 vmlinux.3430sdp.patched
> >
> 
> -- 
> Jouni Högander
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-05-28 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 17:33 [PATCH 0/2] Add D2D clockdomain on OMAP3 ES2+ Paul Walmsley
2008-05-22 17:33 ` [PATCH 1/2] OMAP3 PM: convert open-coded iterator to use pwrdm_for_each_clkdm() Paul Walmsley
2008-05-22 17:33 ` [PATCH 2/2] OMAP3 clockdomains: include D2D clockdomain on 34xx ES2+ Paul Walmsley
2008-05-23  6:27 ` [PATCH 0/2] Add D2D clockdomain on OMAP3 ES2+ Högander Jouni
2008-05-28 20:42   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080528204216.GK8845@atomide.com \
    --to=tony@atomide.com \
    --cc=jouni.hogander@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=r-woodruff2@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.