From: Jens Axboe <jens.axboe@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: block: make blktrace use per-cpu buffers for message notes
Date: Thu, 29 May 2008 09:23:17 +0200 [thread overview]
Message-ID: <20080529072317.GM25504@kernel.dk> (raw)
In-Reply-To: <20080529002016.df6cd8c8.akpm@linux-foundation.org>
On Thu, May 29 2008, Andrew Morton wrote:
> On Thu, 29 May 2008 09:09:15 +0200 Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > So I dug back into the old archives, and the patch was actually done
> > by me back in feb 2006. Not sure I particularly like it or if it
> > even works in this forward ported version, but it should get the
> > point across. blktrace is the sole user of relay_reserve(), so I
> > think it would be OK to change the interface.
> >
> > This is clearly NOT 2.6.26 material though, but it's food for
> > thought (I hope).
>
> hm, it's not pretty, is it. I think I prefer the existing code unless
> there are other users of this.
It is not pretty, it's pretty much a hack :-)
So lets just keep the current code. It's an extra copy, but at
least it's nice'n clean.
--
Jens Axboe
prev parent reply other threads:[~2008-05-29 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200805281559.m4SFx7b9022392@hera.kernel.org>
2008-05-29 6:13 ` block: make blktrace use per-cpu buffers for message notes Andrew Morton
2008-05-29 6:22 ` Jens Axboe
2008-05-29 6:38 ` Andrew Morton
2008-05-29 6:45 ` Jens Axboe
2008-05-29 7:09 ` Jens Axboe
2008-05-29 7:20 ` Andrew Morton
2008-05-29 7:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529072317.GM25504@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.