From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, carlos@strangeworlds.co.uk
Subject: Re: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver
Date: Thu, 29 May 2008 09:07:19 +0100 [thread overview]
Message-ID: <20080529080719.GA16444@srcf.ucam.org> (raw)
In-Reply-To: <20080528224200.0c740819.akpm@linux-foundation.org>
On Wed, May 28, 2008 at 10:42:00PM -0700, Andrew Morton wrote:
> On Wed, 28 May 2008 14:34:25 +0100 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > --- /dev/null
> > +++ b/drivers/misc/hp-wmi.c
>
> I see no Kconfig or Makefile updates.
Oops. Will resend.
> > +static struct key_entry hp_wmi_keymap[] = {
> > + {KE_SW, 0x01, SW_DOCK},
> > + {KE_KEY, 0x02, KEY_BRIGHTNESSUP},
> > + {KE_KEY, 0x03, KEY_BRIGHTNESSDOWN},
> > + {KE_KEY, 0x04, KEY_HELP},
> > + {KE_END, 0}
> > +};
>
> Could be made const. hp_wmi_input_setup() already honours that,
> others will need tweaks.
Not if we want to be able to set the keymap, surely?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-05-29 8:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 16:09 [PATCH] Add switch for dock events Matthew Garrett
2008-05-24 1:23 ` Andrew Morton
2008-05-28 13:06 ` [PATCH 1/3] Input: " Matthew Garrett
2008-05-28 13:21 ` [PATCH 2/3] ACPI: Send switch event on " Matthew Garrett
2008-05-28 13:29 ` [PATCH 3/3] Misc: Add HP WMI laptop extras driver Matthew Garrett
2008-05-29 5:42 ` RESEND: " Andrew Morton
2008-05-29 8:07 ` Matthew Garrett [this message]
2008-05-29 8:23 ` Matthew Garrett
2008-06-02 23:30 ` Andrew Morton
2008-06-07 10:00 ` Carlos Corbacho
2008-05-28 13:34 ` Matthew Garrett
2008-05-29 5:32 ` RESEND: [PATCH 2/3] ACPI: Send switch event on dock events Andrew Morton
2008-05-29 8:15 ` Matthew Garrett
2008-05-29 8:22 ` Version 2: " Matthew Garrett
2008-06-09 9:48 ` Andrew Morton
2008-05-28 13:33 ` RESEND: " Matthew Garrett
2008-05-29 8:20 ` Version 2: [PATCH 1/3] Input: Add switch for " Matthew Garrett
2008-05-28 13:32 ` RESEND: " Matthew Garrett
2008-05-28 13:33 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529080719.GA16444@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.