From: Jens Axboe <jens.axboe@oracle.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH/RFC] virtio_blk: check for hardsector size from host
Date: Thu, 29 May 2008 10:30:05 +0200 [thread overview]
Message-ID: <20080529083004.GQ25504@kernel.dk> (raw)
In-Reply-To: <200805291027.25369.borntraeger@de.ibm.com>
On Thu, May 29 2008, Christian Borntraeger wrote:
> Am Donnerstag, 29. Mai 2008 schrieb Jens Axboe:
> > > > Just that u64 seems like overkill: u32?
> > >
> > > Definitely, u32 would be just fine, u64 is way overkill :-)
> >
> > Even u16 would work, the block layer doesn't use more than an unsigned
> > short for storing hardware sector size anyway.
>
> Thanks, good to know. Do you think, that could change in the future?
> The virtio definition is going to be a public interface, so if there
> is a chance that u16 is not enough in the future I would respin the
> patch with u32, otherwise u16.
I'd say go with the u32, it's the safest option for an exported
interface.
--
Jens Axboe
next prev parent reply other threads:[~2008-05-29 8:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 9:04 [PATCH/RFC] virtio_blk: check for hardsector size from host Christian Borntraeger
2008-05-29 8:04 ` Rusty Russell
2008-05-29 8:11 ` Christian Borntraeger
2008-05-29 8:11 ` Christian Borntraeger
2008-05-29 8:12 ` Jens Axboe
2008-05-29 8:13 ` Jens Axboe
2008-05-29 8:27 ` Christian Borntraeger
2008-05-29 8:30 ` Jens Axboe
2008-05-29 8:30 ` Jens Axboe [this message]
2008-05-29 9:08 ` [PATCH] virtio_config: fix len calculation of config elements Christian Borntraeger
2008-05-30 3:18 ` Rusty Russell
2008-05-30 3:18 ` Rusty Russell
2008-05-29 9:08 ` Christian Borntraeger
2008-05-29 9:08 ` [PATCH v2] virtio_blk: check for hardsector size from host Christian Borntraeger
2008-05-30 3:41 ` Rusty Russell
2008-05-30 3:41 ` Rusty Russell
2008-05-29 9:08 ` Christian Borntraeger
2008-05-29 8:27 ` [PATCH/RFC] " Christian Borntraeger
2008-05-29 8:13 ` Jens Axboe
2008-05-29 8:12 ` Jens Axboe
2008-05-29 8:04 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2008-05-27 9:04 Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529083004.GQ25504@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.