From: Jens Axboe <jens.axboe@oracle.com>
To: "Carlos R. Mafra" <crmafra2@gmail.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
npiggin@suse.de, linux-arch@vger.kernel.org, jeremy@goop.org,
mingo@elte.hu, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] on_each_cpu(): kill unused 'retry' parameter
Date: Thu, 29 May 2008 14:54:29 +0200 [thread overview]
Message-ID: <20080529125429.GE25504@kernel.dk> (raw)
In-Reply-To: <20080529125151.GA25124@Pilar.ictp.trieste.it>
On Thu, May 29 2008, Carlos R. Mafra wrote:
> Hi,
>
> Just a naive comment/question:
>
> > - if (on_each_cpu(ipi_imb, NULL, 1, 1))
> > + if (on_each_cpu(ipi_imb, NULL, 1))
>
> A few weeks ago I though about removing the second argument
> from on_each_cpu, which is NULL more or less 70% of the time.
>
> Do you think it is possible?
> Have you already thought about it?
It's the data argument to the function, I highly doubt you can get
rid of that I'm afraid. on_each_cpu() is just a thin wrapper on
top of smp_call_function() so that the caller doesn't have to
care about manually calling on the local CPU. So as long as
smp_call_function() has a data argument, on_each_cpu() should
carry it as well.
So nope, I don't think that's feasible (or even desired).
--
Jens Axboe
next prev parent reply other threads:[~2008-05-29 12:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 9:00 [PATCH 0/2] Kill unused parameter to smp_call_function and friends Jens Axboe
2008-05-29 9:01 ` [PATCH 1/2] smp_call_function: get rid of the unused nonatomic/retry argument Jens Axboe
2008-05-29 9:01 ` [PATCH 2/2] on_each_cpu(): kill unused 'retry' parameter Jens Axboe
2008-05-29 12:51 ` Carlos R. Mafra
2008-05-29 12:54 ` Jens Axboe [this message]
2008-05-29 13:14 ` Carlos R. Mafra
2008-05-30 11:27 ` Paul E. McKenney
2008-05-30 11:27 ` Paul E. McKenney
2008-05-29 10:09 ` [PATCH 0/2] Kill unused parameter to smp_call_function and friends Jeremy Fitzhardinge
2008-05-29 11:49 ` Jens Axboe
2008-05-29 10:41 ` Alan Cox
2008-05-29 11:47 ` Jens Axboe
2008-05-31 20:45 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529125429.GE25504@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=crmafra2@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.