All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark Fasheh <mfasheh@suse.com>,
	linux-fsdevel@vger.kernel.org, Josef Bacik <jbacik@redhat.com>
Subject: Re: [PATCH 1/5] vfs: vfs-level fiemap interface
Date: Thu, 29 May 2008 11:02:16 -0600	[thread overview]
Message-ID: <20080529170216.GD2985@webber.adilger.int> (raw)
In-Reply-To: <20080529130437.GD21299@infradead.org>

On May 29, 2008  09:04 -0400, Christoph Hellwig wrote:
> On Thu, May 29, 2008 at 11:24:35AM +1000, Dave Chinner wrote:
> > To fix this, FIECOUNT becomes much more complex however other
> > existing interfaces will still expose conflicting information (e.g.
> > XFS_IOC_FSGETXATTR). Hence I don't think extent merging is a
> > good idea in general for this API. For specific implementations
> > it could be considered (e.g. the block-based filesystem wrappers)
> > but it should not forced on all implementations.
> 
> Yes.  Extent merging only really makes sense for block based
> filesystems, and there should be an output flag telling the user
> that this happened.

I've accepted that extent merging is a bad idea for the generic interface.
I think for block-mapped filesystems this pretty much has to happen.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  reply	other threads:[~2008-05-29 17:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25  0:01 [PATCH 1/5] vfs: vfs-level fiemap interface Mark Fasheh
2008-05-25  7:28 ` Andreas Dilger
2008-05-27 18:31   ` Mark Fasheh
2008-05-28 16:09     ` Andreas Dilger
2008-05-28 17:24       ` Joel Becker
2008-05-29 23:46         ` Andreas Dilger
2008-05-30  0:15           ` Mark Fasheh
2008-05-30 17:24             ` Andreas Dilger
2008-05-28 19:42 ` Andreas Dilger
2008-05-28 19:54   ` Josef Bacik
2008-05-28 20:12     ` Mark Fasheh
2008-05-28 20:19       ` Josef Bacik
2008-05-28 21:23   ` Mark Fasheh
2008-05-29  1:24   ` Dave Chinner
2008-05-29 13:04     ` Christoph Hellwig
2008-05-29 17:02       ` Andreas Dilger [this message]
2008-05-31  8:16         ` Christoph Hellwig
2008-05-29 13:03   ` Christoph Hellwig
2008-06-05  5:18 ` Andreas Dilger
2008-06-05 21:35   ` jim owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080529170216.GD2985@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=hch@infradead.org \
    --cc=jbacik@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.