From: Dave Jones <davej@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam
Date: Thu, 29 May 2008 14:41:06 -0400 [thread overview]
Message-ID: <20080529184106.GB24408@redhat.com> (raw)
In-Reply-To: <483EF385.3000103@garzik.org>
On Thu, May 29, 2008 at 02:18:45PM -0400, Jeff Garzik wrote:
> Dave Jones wrote:
> > Make PIO/MMIO a runtime thing via a module parameter.
> > This is needed to support devices that only work with PIO
> > without penalising devices that work fine with MMIO in
> > distro kernels.
> >
> > Signed-off-by: Dave Jones <davej@redhat.com>
>
> two comments:
>
> 1) should use pci_iomap() for both PIO and MMIO
>
> 2) modparam should be "use_io" mirroring existing drivers
Ok, I'll take a stab at those later today (and also your comment
from the other mail).
One other thing: I wasn't sure about my changes to rtl8139_get_regs
and rtl8139_get_regs_len. Is what I did there safe?
Obviously actually implementing support for PIO reg dumping would
be better, but I think that's beyond the scope of what I'm trying
to do for now.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-05-29 18:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 17:14 odd RTL8139 quirk Dave Jones
2008-04-29 19:37 ` Jeff Garzik
2008-04-29 19:47 ` Dave Jones
2008-04-29 21:56 ` Dave Jones
2008-04-29 22:04 ` Jeff Garzik
2008-04-29 22:10 ` Dave Jones
2008-04-29 22:19 ` Jeff Garzik
2008-04-29 22:28 ` Dave Jones
2008-04-29 22:33 ` Jeff Garzik
2008-04-29 22:32 ` Andrew Morton
2008-04-30 11:13 ` Jeff Garzik
2008-04-30 15:19 ` Stephen Hemminger
2008-05-29 15:06 ` Dave Jones
2008-05-29 15:07 ` [PATCH 1/2] 8139too: Make PIO/MMIO a modparam Dave Jones
2008-05-29 18:18 ` Jeff Garzik
2008-05-29 18:41 ` Dave Jones [this message]
2008-05-29 19:01 ` Jeff Garzik
2008-07-15 18:40 ` Dave Jones
2008-07-15 22:18 ` Jeff Garzik
2008-07-15 22:36 ` Dave Jones
2008-07-15 22:55 ` Jeff Garzik
2008-07-15 23:14 ` Dave Jones
2008-07-15 23:31 ` Jeff Garzik
2008-07-15 23:40 ` Dave Jones
2008-07-16 10:03 ` Peter Korsgaard
2008-07-15 22:54 ` Dave Jones
2008-07-15 23:03 ` Jeff Garzik
2008-07-15 23:15 ` Dave Jones
2008-05-29 15:08 ` [PATCH 2/2] 8139too: Make the OQO2 automatically use PIO mode Dave Jones
2008-05-29 18:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529184106.GB24408@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.