From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: Jordi Mallach <jordi@sindominio.net>
Subject: Re: [PATCH] arbitrary drive names in device.map
Date: Fri, 30 May 2008 12:50:19 +0200 [thread overview]
Message-ID: <20080530105019.GB21035@thorin> (raw)
In-Reply-To: <1212102772.4265.53.camel@dv>
On Thu, May 29, 2008 at 07:12:52PM -0400, Pavel Roskin wrote:
> On Wed, 2008-05-28 at 23:36 +0200, Robert Millan wrote:
> > Hi,
> >
> > This patch fixed the device.map handlers to accept any device name for grub
> > drives, rather than just BIOS-style "hd[0-9]" and "fd[0-9]". It makes
> > update-grub usable on OFW, Coreboot, etc.
> >
> > Any comments?
>
> That's a very welcome change!
Ok. Committed.
> By the way, biosdisk.c becomes a misnomer. If I understand correctly,
> biosdisk.c is not going to be emulating anything BIOS specific with your
> patch.
How about renaming to util/disk.c ?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-05-30 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 21:36 [PATCH] arbitrary drive names in device.map Robert Millan
2008-05-29 23:12 ` Pavel Roskin
2008-05-30 10:50 ` Robert Millan [this message]
2008-05-30 16:28 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530105019.GB21035@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
--cc=jordi@sindominio.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.