From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229AbYEaCpU (ORCPT ); Fri, 30 May 2008 22:45:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751383AbYEaCpF (ORCPT ); Fri, 30 May 2008 22:45:05 -0400 Received: from main.gmane.org ([80.91.229.2]:37626 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbYEaCpD (ORCPT ); Fri, 30 May 2008 22:45:03 -0400 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Stephen Hemminger Subject: Re: [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32 Date: Fri, 30 May 2008 19:41:13 -0700 Organization: Linux Foundation Message-ID: <20080530194113.25b77988@extreme> References: <482DA5B6.1020606@sngx.net> <482DB46A.8020103@cosmosbay.com> <482EF192.4070707@sngx.net> <482F5113.5090703@cosmosbay.com> <482F610D.2080108@sngx.net> <20080518003104.GK28241@solarflare.com> <482FBA09.80201@sngx.net> <483E0AAE.2020107@sngx.net> <20080528221118.63da4092.akpm@linux-foundation.org> <483EA2D1.8050603@sngx.net> <20080529154525.3916c7b5@core> <20080530151250.b44a119a.billfink@mindspring.com> <48407C51.7090405@hp.com> <20080530210931.5970c975.billfink@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pool-71-245-98-107.ptldor.fios.verizon.net In-Reply-To: <20080530210931.5970c975.billfink@mindspring.com> X-Newsreader: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Cc: netdev@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 May 2008 21:09:31 -0400 Bill Fink wrote: > On Fri, 30 May 2008, Rick Jones wrote: > > > > Saving stats output and running beforeafter on a number of systems is > > > a royal pain when troubleshooting. > > > > Well, with that ringing endorsement :) I would like to state that > > Yoshihiro Ishijima has fixed some bugs in beforeafter and it will now > > deal with /proc/interrupts output better than before. > > > > ftp://ftp.cup.hp.com/dist/networking/tools/ > > Nothing against beforefter. It's a very useful tool, especially > given Linux's lack of a method to clear interface counters. But > it still is very cumbersome to use in the scenario I mentioned, > having to save the stats before and after a test on each of several > systems, and then having to run beforeafter on each of those systems. > Then you need to do this all again for every test run. It's just > not very efficient. > > I don't know why the major objection to adding a small amount of > code to the kernel that would make life a lot easier for hundreds > (or more) of Linux network adminstrators. And the snapshot/diff > idea would not be complex to maintain and would also address the > issue of some hardware not having a clear hw stats capability. > > -Bill ifstat from iproute2 tools also keeps state to compute number of packets since last update as well. Come on, it isn't that hard. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32 Date: Fri, 30 May 2008 19:41:13 -0700 Message-ID: <20080530194113.25b77988@extreme> References: <482DA5B6.1020606@sngx.net> <482DB46A.8020103@cosmosbay.com> <482EF192.4070707@sngx.net> <482F5113.5090703@cosmosbay.com> <482F610D.2080108@sngx.net> <20080518003104.GK28241@solarflare.com> <482FBA09.80201@sngx.net> <483E0AAE.2020107@sngx.net> <20080528221118.63da4092.akpm@linux-foundation.org> <483EA2D1.8050603@sngx.net> <20080529154525.3916c7b5@core> <20080530151250.b44a119a.billfink@mindspring.com> <48407C51.7090405@hp.com> <20080530210931.5970c975.billfink@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org To: netdev@vger.kernel.org Return-path: Received: from main.gmane.org ([80.91.229.2]:52471 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbYEaClb (ORCPT ); Fri, 30 May 2008 22:41:31 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K2H26-0008WL-3H for netdev@vger.kernel.org; Sat, 31 May 2008 02:41:26 +0000 Received: from pool-71-245-98-107.ptldor.fios.verizon.net ([71.245.98.107]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 31 May 2008 02:41:26 +0000 Received: from shemminger by pool-71-245-98-107.ptldor.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 31 May 2008 02:41:26 +0000 In-Reply-To: <20080530210931.5970c975.billfink@mindspring.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 30 May 2008 21:09:31 -0400 Bill Fink wrote: > On Fri, 30 May 2008, Rick Jones wrote: > > > > Saving stats output and running beforeafter on a number of systems is > > > a royal pain when troubleshooting. > > > > Well, with that ringing endorsement :) I would like to state that > > Yoshihiro Ishijima has fixed some bugs in beforeafter and it will now > > deal with /proc/interrupts output better than before. > > > > ftp://ftp.cup.hp.com/dist/networking/tools/ > > Nothing against beforefter. It's a very useful tool, especially > given Linux's lack of a method to clear interface counters. But > it still is very cumbersome to use in the scenario I mentioned, > having to save the stats before and after a test on each of several > systems, and then having to run beforeafter on each of those systems. > Then you need to do this all again for every test run. It's just > not very efficient. > > I don't know why the major objection to adding a small amount of > code to the kernel that would make life a lot easier for hundreds > (or more) of Linux network adminstrators. And the snapshot/diff > idea would not be complex to maintain and would also address the > issue of some hardware not having a clear hw stats capability. > > -Bill ifstat from iproute2 tools also keeps state to compute number of packets since last update as well. Come on, it isn't that hard.