From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K2Ngj-0006OT-2F for mharc-grub-devel@gnu.org; Sat, 31 May 2008 05:47:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2Ngh-0006O0-OA for grub-devel@gnu.org; Sat, 31 May 2008 05:47:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2Ngd-0006Mg-L0 for grub-devel@gnu.org; Sat, 31 May 2008 05:47:46 -0400 Received: from [199.232.76.173] (port=52105 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2Ngd-0006Mb-F2 for grub-devel@gnu.org; Sat, 31 May 2008 05:47:43 -0400 Received: from aybabtu.com ([69.60.117.155]:52688) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K2NgY-00032h-SK for grub-devel@gnu.org; Sat, 31 May 2008 05:47:43 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K2Nfx-0004tc-Rk for grub-devel@gnu.org; Sat, 31 May 2008 11:47:02 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K2NgJ-0001tZ-5A for grub-devel@gnu.org; Sat, 31 May 2008 11:47:23 +0200 Date: Sat, 31 May 2008 11:47:23 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080531094723.GD6619@thorin> References: <20080530212032.GA1672@thorin> <484075E6.9030709@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <484075E6.9030709@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: backwards compatibility in grub.cfg X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2008 09:47:48 -0000 On Fri, May 30, 2008 at 11:47:18PM +0200, Christian Franke wrote: > Robert Millan wrote: > > >diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp > >../grub2/util/update-grub_lib.in ./util/update-grub_lib.in > >--- ../grub2/util/update-grub_lib.in 2008-05-30 22:55:35.000000000 +0200 > >+++ ./util/update-grub_lib.in 2008-05-30 23:16:53.000000000 +0200 > >@@ -116,10 +116,9 @@ prepare_grub_to_access_device () > > > > # If there's a filesystem UUID that GRUB is capable of identifiing, use > > it; > > # otherwise set root as per value in device.map. > >+ echo "set root=`${grub_probe} --device ${device} --target=drive`" > > if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2> > > /dev/null`" ; then > > > > Outside of the scope of the patch, but shouldn't '${grub_probe}' be used > instead of 'grub-probe' in the rest of the script? > > Same issue is in update-grub.in: grub_probe is set but never used, so > update-grub fails if /usr/sbin is not in PATH. Fixed. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)