From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.riseup.net ([204.13.164.18]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1K2RTK-0000sL-2s for linux-mtd@lists.infradead.org; Sat, 31 May 2008 13:50:15 +0000 Resent-Message-ID: <20080531133004.GG3075@traven> Message-Id: <20080531132809.319282660@kaehlcke.net> References: <20080531132808.644758754@kaehlcke.net> Date: Sat, 31 May 2008 15:28:10 +0200 From: matthias@kaehlcke.net To: dwmw2@infradead.org, linux-mtd@lists.infradead.org Subject: [patch 2/2] MTD: use list_for_each_entry() in del_mtd_device() Content-Disposition: inline; filename=mtd-del_mtd_device-use-list_for_each_entry.patch Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MTD: use list_for_each_entry() instead of list_for_each() in del_mtd_device() Signed-off-by: Matthias Kaehlcke Index: linux-2.6/drivers/mtd/mtdcore.c =================================================================== --- linux-2.6.orig/drivers/mtd/mtdcore.c 2008-05-31 15:18:13.000000000 +0200 +++ linux-2.6/drivers/mtd/mtdcore.c 2008-05-31 15:21:04.000000000 +0200 @@ -112,12 +112,11 @@ mtd->index, mtd->name, mtd->usecount); ret = -EBUSY; } else { - struct list_head *this; + struct mtd_notifier *not; /* No need to get a refcount on the module containing the notifier, since we hold the mtd_table_mutex */ - list_for_each(this, &mtd_notifiers) { - struct mtd_notifier *not = list_entry(this, struct mtd_notifier, list); + list_for_each_entry(not, &mtd_notifiers, list) { not->remove(mtd); } -- Matthias Kaehlcke Embedded Linux Engineer Barcelona We build too many walls and not enough bridges (Isaac Newton) .''`. using free software / Debian GNU/Linux | http://debian.org : :' : `. `'` gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbYEaNb0 (ORCPT ); Sat, 31 May 2008 09:31:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753368AbYEaNaO (ORCPT ); Sat, 31 May 2008 09:30:14 -0400 Received: from mx1.riseup.net ([204.13.164.18]:44799 "EHLO mx1.riseup.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbYEaNaM (ORCPT ); Sat, 31 May 2008 09:30:12 -0400 Message-Id: <20080531132809.319282660@kaehlcke.net> References: <20080531132808.644758754@kaehlcke.net> User-Agent: quilt/0.46-1 Date: Sat, 31 May 2008 15:28:10 +0200 From: matthias@kaehlcke.net To: dwmw2@infradead.org, linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Matthias Kaehlcke Subject: [patch 2/2] MTD: use list_for_each_entry() in del_mtd_device() Content-Disposition: inline; filename=mtd-del_mtd_device-use-list_for_each_entry.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MTD: use list_for_each_entry() instead of list_for_each() in del_mtd_device() Signed-off-by: Matthias Kaehlcke Index: linux-2.6/drivers/mtd/mtdcore.c =================================================================== --- linux-2.6.orig/drivers/mtd/mtdcore.c 2008-05-31 15:18:13.000000000 +0200 +++ linux-2.6/drivers/mtd/mtdcore.c 2008-05-31 15:21:04.000000000 +0200 @@ -112,12 +112,11 @@ mtd->index, mtd->name, mtd->usecount); ret = -EBUSY; } else { - struct list_head *this; + struct mtd_notifier *not; /* No need to get a refcount on the module containing the notifier, since we hold the mtd_table_mutex */ - list_for_each(this, &mtd_notifiers) { - struct mtd_notifier *not = list_entry(this, struct mtd_notifier, list); + list_for_each_entry(not, &mtd_notifiers, list) { not->remove(mtd); } -- Matthias Kaehlcke Embedded Linux Engineer Barcelona We build too many walls and not enough bridges (Isaac Newton) .''`. using free software / Debian GNU/Linux | http://debian.org : :' : `. `'` gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-