From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K2Stz-0005M0-Ap for mharc-grub-devel@gnu.org; Sat, 31 May 2008 11:21:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2Stx-0005Ky-Be for grub-devel@gnu.org; Sat, 31 May 2008 11:21:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2Stv-0005If-9W for grub-devel@gnu.org; Sat, 31 May 2008 11:21:48 -0400 Received: from [199.232.76.173] (port=48381 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2Stv-0005Ic-6Y for grub-devel@gnu.org; Sat, 31 May 2008 11:21:47 -0400 Received: from aybabtu.com ([69.60.117.155]:32863) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K2Stv-0005t4-4a for grub-devel@gnu.org; Sat, 31 May 2008 11:21:47 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K2StL-0005Ln-Gi; Sat, 31 May 2008 17:21:12 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K2StZ-0003kz-FD; Sat, 31 May 2008 17:21:25 +0200 Date: Sat, 31 May 2008 17:21:25 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080531152125.GA14263@thorin> References: <20080531101042.GF6619@thorin> <20080531113901.GA20946@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: "Yoshinori K. Okuji" Subject: Re: [PATCH] Environment block support for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2008 15:21:49 -0000 On Sat, May 31, 2008 at 08:09:50PM +0800, Bean wrote: > On Sat, May 31, 2008 at 7:39 PM, Robert Millan wrote: > > > > I think the method is sound; what I'm complaining about (and it's not > > something specific to your patch) is that we're referring to two different > > things by the same name ("root"), and even put them in the same variable. > > > > In the initialization phase, "root" is the device that contains our GRUB > > directory. > > > > Afterwards, "root" is the device we're currently accessing (be it for loading > > fonts, backgrounds, Linux images, whatever). > > > > If "root" means "just a placeholder for whatever device we're acessing at the > > moment", then it would make sense, but in our code (i.e. in the names we're > > giving to commands and functions) it's assumed to mean "the device containing > > /boot/grub". > > > > So what do we want to do with this? Should we have different variables for > > each thing (and in that case, is "root" for initial stage or for grub.cfg) > > or should we use "root" as a placeholder for any path reference, and adjust > > our function names etc to reflect that? > > root is used in loaders as well, we shouldn't change its name. We > could use another variable to store the root device at initial stage, > it could actually be useful as it always points to the boot media. > Perhaps we can name it "boot". What's your idea ? I'm fine with "boot". I'm CCing Okuji; would like to make sure he doesn't have any objections (I think it was he who gave it this layout). -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)