From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K2SIh-0001AA-BP for mharc-grub-devel@gnu.org; Sat, 31 May 2008 10:43:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2SIf-00019b-RN for grub-devel@gnu.org; Sat, 31 May 2008 10:43:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2SId-00018e-CX for grub-devel@gnu.org; Sat, 31 May 2008 10:43:17 -0400 Received: from [199.232.76.173] (port=38647 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2SId-00018Z-7C for grub-devel@gnu.org; Sat, 31 May 2008 10:43:15 -0400 Received: from ctb-mesg-2-3.saix.net ([196.25.240.83]:51459) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2SIc-0007kq-NN for grub-devel@gnu.org; Sat, 31 May 2008 10:43:15 -0400 Received: from molech (dsl-241-87-150.telkomadsl.co.za [41.241.87.150]) by ctb-mesg-2-3.saix.net (Postfix) with ESMTP id EA3A5FB92 for ; Sat, 31 May 2008 16:42:57 +0200 (SAST) Resent-From: Michael Gorven Resent-To: The development of GRUB 2 Resent-Date: Sat, 31 May 2008 16:42:50 +0200 Resent-Message-ID: <200805311642.50539.michael@gorven.za.net> To: The development of GRUB 2 From: Michael Gorven Date: Sat, 31 May 2008 16:42:14 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1507902.Pbm3Zy8XT7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200805311642.14955.michael@gorven.za.net> X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Resent-Date: Sat, 31 May 2008 10:43:16 -0400 Subject: [PATCH] vt100 cursor on and off sequences X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2008 14:43:18 -0000 --nextPart1507902.Pbm3Zy8XT7 Content-Type: multipart/mixed; boundary="Boundary-01=_GPWQIomqz8P0Iw0" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_GPWQIomqz8P0Iw0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline I've been testing GRUB using the serial terminal and noticed that there was= no=20 cursor (and that my terminal window also lost its cursor after running GRUB= ).=20 I looked into this today and found that the escape sequences for turning th= e=20 cursor on and off were the wrong way round. The attached patch fixes this s= o=20 that the serial terminal now has a cursor :-) Michael =2D-=20 http://michael.gorven.za.net PGP Key ID 6612FE85 S/MIME Key ID D33AEB31 --Boundary-01=_GPWQIomqz8P0Iw0 Content-Type: text/x-diff; charset="utf-8"; name="vt100-cursor.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="vt100-cursor.diff" diff -rN -u old-grub-devel/ChangeLog new-grub-devel/ChangeLog =2D-- old-grub-devel/ChangeLog 2008-05-31 16:31:29.000000000 +0200 +++ new-grub-devel/ChangeLog 2008-05-31 16:31:29.000000000 +0200 @@ -1,3 +1,8 @@ +2008-05-31 Michael Gorven + + * term/terminfo.c (grub_terminfo_set_current): Correct vt100 cursor + on and off sequences. + 2008-05-31 Robert Millan =20 * util/update-grub_lib.in: Replace `grub-probe' with `${grub_probe}'. diff -rN -u old-grub-devel/term/terminfo.c new-grub-devel/term/terminfo.c =2D-- old-grub-devel/term/terminfo.c 2008-05-31 16:31:29.000000000 +0200 +++ new-grub-devel/term/terminfo.c 2008-05-31 16:31:29.000000000 +0200 @@ -98,8 +98,8 @@ term.cls =3D grub_strdup ("\e[H\e[J"); term.reverse_video_on =3D grub_strdup ("\e[7m"); term.reverse_video_off =3D grub_strdup ("\e[m"); =2D term.cursor_on =3D grub_strdup ("\e[?25l"); =2D term.cursor_off =3D grub_strdup ("\e[?25h"); + term.cursor_on =3D grub_strdup ("\e[?25h"); + term.cursor_off =3D grub_strdup ("\e[?25l"); return grub_errno; } =20 --Boundary-01=_GPWQIomqz8P0Iw0-- --nextPart1507902.Pbm3Zy8XT7 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBIQWPGO9SWvWYS/oURAlfxAKCtIjCggcBP3fRVmuZGrO1v8nS5aQCgl/hq Dwai9SgYkgACQhBH8Im57ks= =4HPf -----END PGP SIGNATURE----- --nextPart1507902.Pbm3Zy8XT7--