Re: [kbd] unicode_start should not call setfont

[Michael Schutte <m.schutte.jr@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

On Sun, Jun 01, 2008 at 03:54:21AM +0400, Alexey Gladkov wrote:
> We could do another thing:
>
> diff --git a/src/unicode_start b/src/unicode_start
> index 82ef457..63c9967 100755
> --- a/src/unicode_start
> +++ b/src/unicode_start
> @@ -83,7 +83,6 @@ case "$#" in
>                 setfont "$1"
>                 ;;
>         0)
> -               setfont "$DEFAULT_UNICODE_FONT"
>                 ;;
>         *)
>                 echo "usage: unicode_start [font [unicode map]]"
> ---
>
> Most distributions load own fonts after executing unicode_start. I think we 
> can remove the setting of default font.
>
> Without any arguments unicode_start will only set unicode mode and will not 
> set font.
>
> How about that?

This is exactly what I had in mind, I just failed to express myself :-)

Just an addition to your patch, before it gets forgotten:

diff --git a/man/man1/unicode_start.1 b/man/man1/unicode_start.1
index 7c2b939..b76ccb3 100644
--- a/man/man1/unicode_start.1
+++ b/man/man1/unicode_start.1
@@ -26,7 +26,7 @@ The parameter
 .I font
 is a font that is loaded. It should have a built-in Unicode map,
 or, if it hasn't, such a map can be given explicitly as second parameter.
-When no font was specified, some default font is loaded.
+When no font was specified, the current font is kept.
 .SH NOTE
 Unicode mode is a parameter with a value per virtual console.
 However, usually the font and keymap is common to all consoles.
diff --git a/src/unicode_start b/src/unicode_start
index cfa19f8..7351fe0 100755
--- a/src/unicode_start
+++ b/src/unicode_start
@@ -85,18 +85,6 @@ stty iutf8
 # have a Unicode map attached, or explicitly specified, e.g.,
 # by giving `def.uni' as a second argument.
 
-# Also drdos8x16 is a good candidate.
-for DEFAULT_UNICODE_FONT in \
-       /usr/share/consolefonts/Uni1-VGA16.psf* \
-       /usr/share/consolefonts/LatArCyrHeb-16.psf* \
-       /usr/share/consolefonts/default*.psf* \
-       /usr/share/consolefonts/*.psf*
-do
-       if [ -f "$DEFAULT_UNICODE_FONT" ]; then
-               break
-       fi
-done
-
 case "$#" in
        2)
                setfont "$1" -u "$2"
---

I’ll apply this for the next Debian revision of kbd.

Regards,
-- 
Michael Schutte <m.schutte.jr@gmail.com>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 481 bytes --]