From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
airlied@linux.ie, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: make drm use create_proc_read_entry() instead
Date: Sun, 1 Jun 2008 10:36:00 +0100 [thread overview]
Message-ID: <20080601093600.GL28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080601092546.GA4967@martell.zuzino.mipt.ru>
On Sun, Jun 01, 2008 at 01:25:46PM +0400, Alexey Dobriyan wrote:
> On Sat, May 31, 2008 at 09:48:21PM -0700, Arjan van de Ven wrote:
> > Subject: [PATCH] drm: make drm use create_proc_read_entry() instead
> >
> > Al Viro points out that DRM should have used create_proc_read_entry(),
> > and although that is still racey right now, it at least has a chance
> > of getting fixed on the api level.
>
> Fix on API level is proc_create_data(), so this patch is pointless.
Yeah... OTOH, it might make sense to reorder assignments in the
create_proc_read_entry() and slap the barrier in there - it would
close at least some of the holes until we get around to proper
proc_create_data() conversions and remove the ->read_proc() crap...
next prev parent reply other threads:[~2008-06-01 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 3:39 [PATCH] drm: fix crash due to /proc registration race Arjan van de Ven
2008-06-01 4:48 ` [PATCH] drm: make drm use create_proc_read_entry() instead Arjan van de Ven
2008-06-01 9:25 ` Alexey Dobriyan
2008-06-01 9:36 ` Al Viro [this message]
2008-06-01 10:10 ` [PATCH] drm: switch to seq_files Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601093600.GL28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=airlied@linux.ie \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.