All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Rsync cannot copy to a vfat partition on kernel 2.6.25
Date: Sun, 1 Jun 2008 22:32:29 +0200	[thread overview]
Message-ID: <20080601203229.GA5615@ucw.cz> (raw)
In-Reply-To: <87prr36284.fsf@duaron.myhome.or.jp>

Hi!

> > We had a user report at https://bugzilla.redhat.com/show_bug.cgi?id=449080
> > that in 2.6.25, he can no longer rsync to a vfat partition, even as root.
> > I just reproduced this here. It gets -EPERM in the mkstemp call.
> > (full strace in the bug report).
> >
> > Did we change behaviour somehow in the vfat code?
> > 2.6.24.7 works fine apparently.
> 
> Yes, it was changed. New one allows only acceptable chmod(), and if not
> acceptable, it returns -EPERM. Old one allows even if it can't store the
> disk inode. But it may be too strict for users.

Hmm... but I guess mkstemp is no longer safe with this?

So we have choice between security hole and regression...?

							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-06-01 20:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-449080-176318@bugzilla.redhat.com>
     [not found] ` <200805301659.m4UGx3AW001503@bz-web2.app.phx.redhat.com>
2008-05-30 17:14   ` Rsync cannot copy to a vfat partition on kernel 2.6.25 Dave Jones
2008-05-30 19:06     ` OGAWA Hirofumi
2008-06-01 20:32       ` Pavel Machek [this message]
2008-06-01 21:12         ` OGAWA Hirofumi
2008-06-01 21:15           ` OGAWA Hirofumi
2008-06-01 21:26           ` OGAWA Hirofumi
2008-06-01 21:29             ` OGAWA Hirofumi
2008-06-01 22:09           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080601203229.GA5615@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=davej@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.