From: Ben Hutchings <bhutchings@solarflare.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: eilong@broadcom.com, netdev <netdev@vger.kernel.org>,
jeff@garzik.org, davem@davemloft.net,
Eliezer Tamir <eliezert@broadcom.com>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x_link
Date: Sun, 1 Jun 2008 23:37:49 +0100 [thread overview]
Message-ID: <20080601223748.GI30769@solarflare.com> (raw)
In-Reply-To: <87tzgc283g.fsf@basil.nowhere.org>
Andi Kleen wrote:
[...]
> > +/* Programs an image to DSP's flash via the SPI port*/
> > +static u8 bnx2x_sfx7101_flash_download(struct bnx2x *bp, u8 port,
> > + u8 ext_phy_addr,
> > + char data[], u32 size)
>
> Hmm does the driver really need a flash updater as standard
> functionality? That could be a separate program.
[...]
It shouldn't need to do this. The boot loader in the SFX7101 allows
flash update through MDIO if the appropriate pin is pulled low at
reset (see phy_flash_cfg option in the sfc driver). Of course that
doesn't help if the board doesn't allow this to be controlled...
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-06-01 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 15:12 [PATCH net-next 2/13]bnx2x: Adding bnx2x_link Eilon Greenstein
2008-06-01 20:50 ` Andi Kleen
2008-06-01 22:37 ` Ben Hutchings [this message]
2008-06-03 6:31 ` Eilon Greenstein
2008-06-03 13:46 ` Eliezer Tamir
2008-06-04 14:34 ` MDIO clause 45 (was Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x_link) Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601223748.GI30769@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eliezert@broadcom.com \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.