All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC][PATCH 4/6] delalloc ENOSPC: avoid free blocks  double booking
Date: Mon, 2 Jun 2008 13:29:34 +0530	[thread overview]
Message-ID: <20080602075934.GA29995@skywalker> (raw)
In-Reply-To: <1212390756.4368.113.camel@localhost.localdomain>

On Mon, Jun 02, 2008 at 12:12:36AM -0700, Mingming Cao wrote:
> On Mon, 2008-06-02 at 12:21 +0530, Aneesh Kumar K.V wrote:
> > On Sun, Jun 01, 2008 at 04:36:10PM -0700, Mingming Cao wrote:
> > > ext4: delalloc block reservation avoid double accounting
> > > 
> > > From: Mingming cao <cmm@us.ibm.com>
> > > 
> > > Since fs free blocks counters are already reduced at the block reservation
> > > time, we need to let the underlying block allocation know to avoid
> > > decrease the free blocks counter again when real block allocation finished.
> > > 
> > > Signed-off-by: Mingming cao <cmm@us.ibm.com>
> > > ---
> > >  fs/ext4/dir.c     |    3 ++-
> > >  fs/ext4/ext4.h    |    6 +++++-
> > >  fs/ext4/ext4_i.h  |    1 +
> > >  fs/ext4/extents.c |    2 +-
> > >  fs/ext4/inode.c   |   25 ++++++++++++++++++-------
> > >  fs/ext4/mballoc.c |   13 ++++++++++++-
> > >  fs/ext4/super.c   |    2 ++
> > >  7 files changed, 41 insertions(+), 11 deletions(-)
> > > 
> > 
> > I guess you would need a similar change for balloc.c 
> > 
> 
> I haven't try delaloc on non-extent files yet. that's todo after this
> series is settle down. 

how about mount -o nomballoc ?

-aneesh

      reply	other threads:[~2008-06-02  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-01 23:36 [RFC][PATCH 4/6] delalloc ENOSPC: avoid free blocks double booking Mingming Cao
2008-06-02  6:51 ` Aneesh Kumar K.V
2008-06-02  7:12   ` Mingming Cao
2008-06-02  7:59     ` Aneesh Kumar K.V [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080602075934.GA29995@skywalker \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.