From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC][PATCH 3/6] delalloc ENOSPC: reserve blocks
Date: Mon, 2 Jun 2008 14:02:29 +0530 [thread overview]
Message-ID: <20080602083229.GB29995@skywalker> (raw)
In-Reply-To: <1212363355.4368.66.camel@localhost.localdomain>
On Sun, Jun 01, 2008 at 04:35:55PM -0700, Mingming Cao wrote:
> ext4: delalloc ENOSPC handling core
>
> From: Mingming cao <cmm@us.ibm.com>
>
> Core part of delaloc ENOSPC (block reservation.)
> data/meta blocks are reserved on write_begin(), and per-inode reserved counters
> are updated after block allocation.
I am not clear about ext4_da_release_space. Are we accounting for the
blocks related to meta-data blocks allocated ? . In
ext4_da_get_block_write we get the number of data blocks allocated.
and we don't update sbi->s_freeblocks_counter in the block allocator
any more. So request for meta-data blocks are not updating the
sbi->s_freeblocks_counter. In ext4_da_release_space we update
the sbi->s_freeblocks_counter without considering the above. Am I
missing something ?
-aneesh
prev parent reply other threads:[~2008-06-02 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 23:35 [RFC][PATCH 3/6] delalloc ENOSPC: reserve blocks Mingming Cao
2008-06-02 6:44 ` Aneesh Kumar K.V
2008-06-02 6:55 ` Aneesh Kumar K.V
2008-06-02 8:32 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602083229.GB29995@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.