From: Joe Korty <joe.korty@ccur.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>, Theodore Tso <tytso@mit.edu>,
Gabriel C <nix.or.die@googlemail.com>,
Keith Packard <keithp@keithp.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Eric Anholt <eric@anholt.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
bugme-daemon@bugzilla.kernel.org, airlied@linux.ie, "Barnes,
Jesse" <jesse.barnes@intel.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Fix for asm warning in head_32.S
Date: Mon, 2 Jun 2008 17:21:06 -0400 [thread overview]
Message-ID: <20080602212106.GA25959@tsunami.ccur.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0805191528550.32253@woody.linux-foundation.org>
On Mon, May 19, 2008 at 04:10:02PM -0700, Linus Torvalds wrote:
> It also causes these warnings on 32-bit PAE:
>
> AS arch/x86/kernel/head_32.o
> arch/x86/kernel/head_32.S: Assembler messages:
> arch/x86/kernel/head_32.S:225: Warning: left operand is a bignum; integer 0 assumed
> arch/x86/kernel/head_32.S:609: Warning: left operand is a bignum; integer 0 assumed
>
> and I do not see why (the end result seems to be identical).
Fix head_32.S gcc bignum warnings when CONFIG_PAE=y.
arch/x86/kernel/head_32.S: Assembler messages:
arch/x86/kernel/head_32.S:225: Warning: left operand is a bignum; integer 0 assumed
arch/x86/kernel/head_32.S:609: Warning: left operand is a bignum; integer 0 assumed
The assembler was stumbling over the 64-bit constant 0x100000000 in the
KPMDS #define.
Testing: a cmp(1) on head_32.o before and after shows the binary is unchanged.
Signed-off-by: Joe Korty <joe.korty@ccur.com
Index: a/arch/x86/kernel/head_32.S
===================================================================
--- a.orig/arch/x86/kernel/head_32.S 2008-06-02 16:51:20.000000000 -0400
+++ a/arch/x86/kernel/head_32.S 2008-06-02 16:54:05.000000000 -0400
@@ -189,7 +189,7 @@
* this stage.
*/
-#define KPMDS ((0x100000000-__PAGE_OFFSET) >> 30) /* Number of kernel PMDs */
+#define KPMDS (((-__PAGE_OFFSET) >> 30) & 3) /* Number of kernel PMDs */
xorl %ebx,%ebx /* %ebx is kept at zero */
next prev parent reply other threads:[~2008-06-02 21:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 7:32 REGRESSION: 2.6.26-rc2-git4: X server failed start on X61s laptop Theodore Ts'o
2008-05-17 9:49 ` Sitsofe Wheeler
2008-05-17 13:21 ` Pallipadi, Venkatesh
2008-05-17 15:41 ` [Bug 10732] " Theodore Tso
2008-05-17 16:02 ` [Bug 10732] REGRESSION: 2.6.26-rc2-git4: X server failed start onX61s laptop Pallipadi, Venkatesh
2008-05-17 16:53 ` Theodore Tso
2008-05-17 18:11 ` Keith Packard
2008-05-17 18:32 ` Gabriel C
2008-05-17 18:46 ` Theodore Tso
2008-05-19 21:25 ` Hugh Dickins
2008-05-19 23:04 ` Jeremy Fitzhardinge
2008-05-19 23:10 ` Linus Torvalds
2008-05-20 2:33 ` Linus Torvalds
2008-05-20 4:14 ` Hugh Dickins
2008-05-20 7:32 ` Jeremy Fitzhardinge
2008-05-20 7:31 ` Jeremy Fitzhardinge
2008-06-02 21:21 ` Joe Korty [this message]
2008-05-17 16:36 ` [Bug 10732] REGRESSION: 2.6.26-rc2-git4: X server failed start on X61s laptop Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602212106.GA25959@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=eric@anholt.net \
--cc=hugh@veritas.com \
--cc=jeremy@goop.org \
--cc=jesse.barnes@intel.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nix.or.die@googlemail.com \
--cc=rjw@sisk.pl \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.