All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 11/14] cio: remove lock from ccw_device_oper_notify.
Date: Tue, 03 Jun 2008 18:59:10 +0200	[thread overview]
Message-ID: <20080603170520.988639783@de.ibm.com> (raw)
In-Reply-To: 20080603165859.107949986@de.ibm.com

[-- Attachment #1: 110-cio-locking.diff --]
[-- Type: text/plain, Size: 1392 bytes --]

From: Sebastian Ott <sebott@linux.vnet.ibm.com>

Remove unnecessary ccw device locking inside ccw_device_oper_notify.

Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>        
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>        
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/s390/cio/device_fsm.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Index: quilt-2.6/drivers/s390/cio/device_fsm.c
===================================================================
--- quilt-2.6.orig/drivers/s390/cio/device_fsm.c
+++ quilt-2.6/drivers/s390/cio/device_fsm.c
@@ -346,21 +346,15 @@ ccw_device_oper_notify(struct work_struc
 	struct ccw_device_private *priv;
 	struct ccw_device *cdev;
 	int ret;
-	unsigned long flags;
 
 	priv = container_of(work, struct ccw_device_private, kick_work);
 	cdev = priv->cdev;
 	ret = ccw_device_notify(cdev, CIO_OPER);
-	spin_lock_irqsave(cdev->ccwlock, flags);
 	if (ret) {
 		/* Reenable channel measurements, if needed. */
-		spin_unlock_irqrestore(cdev->ccwlock, flags);
 		cmf_reenable(cdev);
-		spin_lock_irqsave(cdev->ccwlock, flags);
 		wake_up(&cdev->private->wait_q);
-	}
-	spin_unlock_irqrestore(cdev->ccwlock, flags);
-	if (!ret)
+	} else
 		/* Driver doesn't want device back. */
 		ccw_device_do_unreg_rereg(work);
 }

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

  parent reply	other threads:[~2008-06-03 16:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 16:58 [patch 00/14] s390 feature patches for 2.6.27 Martin Schwidefsky
2008-06-03 16:59 ` [patch 01/14] cio: Register all subchannels Martin Schwidefsky
2008-06-03 16:59 ` [patch 02/14] cio: Introduce modalias for css bus Martin Schwidefsky
2008-06-03 16:59 ` [patch 03/14] cio: Rework css driver Martin Schwidefsky
2008-06-03 16:59 ` [patch 04/14] cio: Cleanup crw interface Martin Schwidefsky
2008-06-03 16:59 ` [patch 05/14] cio: Export some symbols for modular css drivers Martin Schwidefsky
2008-06-03 16:59 ` [patch 06/14] cio: Base message subchannel handling Martin Schwidefsky
2008-06-03 16:59 ` [patch 07/14] cio: introduce fcx bit to chsc characteristics Martin Schwidefsky
2008-06-03 16:59 ` [patch 08/14] cio: introduce fcx enabled scsw format Martin Schwidefsky
2008-06-03 16:59 ` [patch 09/14] cio: provide functions for fcx enabled I/O Martin Schwidefsky
2008-06-03 16:59 ` [patch 10/14] cio: provide helper " Martin Schwidefsky
2008-06-03 16:59 ` Martin Schwidefsky [this message]
2008-06-03 16:59 ` [patch 12/14] Introduce user_regset accessors for s390 Martin Schwidefsky
2008-06-03 16:59 ` [patch 13/14] initrd vs bss section clearing Martin Schwidefsky
2008-06-03 16:59 ` [patch 14/14] stp support Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603170520.988639783@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sebott@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.