From: Holger Macht <hmacht@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] libata: Handle bay devices in dock stations
Date: Tue, 3 Jun 2008 20:23:27 +0200 [thread overview]
Message-ID: <20080603182106.GA3556@homac> (raw)
In-Reply-To: <20080603181346.GA5013@srcf.ucam.org>
On Tue 03. Jun - 19:13:46, Matthew Garrett wrote:
> On Tue, Jun 03, 2008 at 02:07:42PM -0400, Jeff Garzik wrote:
>
> > It would be nice if you and Holger could work together to produce a
> > single patch[set]... right now I have patches from both of you, and I
> > was sorta waiting on the thread to die down to see if competing patches
> > might merge into a single set
>
> I think we were waiting for feedback from Tejun as to why removing the
> port freeze call fixed the hang I was seeing? Beyond that, Holger's
> latest patch looked good to me.
My suspicion is just that calling ata_port_freeze() on an already frozen
port is not good ;-)
I'll resend the merged patch.
Regards,
Holger
next prev parent reply other threads:[~2008-06-03 18:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 14:38 [PATCH] libata: Handle bay devices in dock stations Holger Macht
2008-05-28 14:39 ` Tejun Heo
2008-05-28 14:39 ` Tejun Heo
2008-05-29 3:02 ` Andrew Morton
2008-05-29 3:08 ` Tejun Heo
2008-05-29 13:22 ` Matthew Garrett
2008-05-29 13:33 ` Holger Macht
2008-05-29 13:32 ` Matthew Garrett
2008-05-29 13:39 ` Holger Macht
2008-05-29 13:40 ` Matthew Garrett
2008-05-29 13:44 ` Tejun Heo
2008-05-29 14:02 ` Matthew Garrett
2008-05-29 14:14 ` Holger Macht
2008-05-29 14:35 ` Matthew Garrett
2008-05-29 14:37 ` Tejun Heo
2008-05-29 14:49 ` Matthew Garrett
2008-05-29 16:32 ` Holger Macht
2008-05-29 16:40 ` Tejun Heo
2008-05-29 16:40 ` Tejun Heo
2008-06-01 16:05 ` Holger Macht
2008-05-29 16:46 ` Holger Macht
2008-05-29 16:46 ` Holger Macht
2008-05-29 17:51 ` Henrique de Moraes Holschuh
2008-05-29 17:51 ` Henrique de Moraes Holschuh
2008-05-30 11:07 ` tom
2008-06-01 16:06 ` Holger Macht
2008-06-03 18:07 ` Jeff Garzik
2008-06-03 18:13 ` Matthew Garrett
2008-06-03 18:23 ` Holger Macht [this message]
2008-06-09 1:44 ` Tejun Heo
2008-06-09 1:48 ` Matthew Garrett
2008-06-09 4:56 ` Tejun Heo
2008-06-03 18:27 ` Holger Macht
2008-06-03 18:29 ` Matthew Garrett
2008-06-03 18:54 ` Jeff Garzik
2008-06-04 10:29 ` Jeff Garzik
2008-06-04 10:29 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-05-31 0:01 Pascal Brückner
2008-05-31 10:28 Pascal Brückner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603182106.GA3556@homac \
--to=hmacht@suse.de \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.