From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them
Date: Tue, 3 Jun 2008 21:43:13 +0100 [thread overview]
Message-ID: <20080603204313.GA9995@shareable.org> (raw)
In-Reply-To: <4845A5C4.6050309@codemonkey.ws>
Anthony Liguori wrote:
> It's sloppy. In general, using a non-portable feature for no good
> reason other than you can is bad practice (even if we do depend on GCC).
It's 2008, the standard is called C99 for a reason.
In 1998, we would have used C89 constructs like function prototypes,
wouldn't we?
:-)
If you don't want to use non-portable features, may I suggest
"gcc -std=c89".
(Half joking, I use -Wdeclaration-after-statement myself to catch
this, since it became a standard GCC feature with no option to turn it
off and keep other GNU extensions. But then, I write code which is
more portable than QEMU and target older architectures.)
-- Jamie
next prev parent reply other threads:[~2008-06-03 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 9:03 [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them Marc Bevand
2008-06-03 19:06 ` Anthony Liguori
2008-06-03 19:40 ` Jamie Lokier
2008-06-03 20:12 ` Anthony Liguori
2008-06-03 20:43 ` Jamie Lokier [this message]
2008-06-03 21:07 ` Andreas Färber
2008-06-03 21:28 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2008-05-28 5:02 [Qemu-devel] [RFC] Allow 'qemu-img convert' to preserve the backing file Marc Bevand
2008-05-28 9:53 ` Ian Jackson
2008-05-28 9:55 ` Ian Jackson
2008-05-30 8:43 ` [Qemu-devel] " Marc Bevand
2008-05-30 9:21 ` [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them Marc Bevand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603204313.GA9995@shareable.org \
--to=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.