From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K3rmr-0006qe-67 for mharc-grub-devel@gnu.org; Wed, 04 Jun 2008 08:08:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3rmo-0006pz-W5 for grub-devel@gnu.org; Wed, 04 Jun 2008 08:08:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3rmm-0006o3-VB for grub-devel@gnu.org; Wed, 04 Jun 2008 08:08:14 -0400 Received: from [199.232.76.173] (port=55603 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3rmm-0006nx-FG for grub-devel@gnu.org; Wed, 04 Jun 2008 08:08:12 -0400 Received: from aybabtu.com ([69.60.117.155]:40910) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3rmm-0005gv-1Y for grub-devel@gnu.org; Wed, 04 Jun 2008 08:08:12 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K3rlp-0001Qt-IB for grub-devel@gnu.org; Wed, 04 Jun 2008 14:07:13 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K3rmX-0006D3-GE for grub-devel@gnu.org; Wed, 04 Jun 2008 14:07:57 +0200 Date: Wed, 4 Jun 2008 14:07:57 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080604120757.GA23648@thorin> References: <20080602135014.GA4563@thorin> <1212415910.3659.0.camel@rd> <20080603211257.GB10712@thorin> <1212530631.11375.4.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1212530631.11375.4.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] register dummy drive X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 12:08:15 -0000 On Tue, Jun 03, 2008 at 06:03:51PM -0400, Pavel Roskin wrote: > > > > > > > > This patch solves the problem by spliting device/drive map[] entry registration > > > > into a separate function, and using that from grub-probe.c to register a dummy > > > > drive that will last during the current execution. > > > > Part of what makes grub-probe interesting is that it shares a lot of code with > > the freestanding GRUB you will run later, so when it is used during > > grub-install & update-grub, it is very useful to catch possible problems. I > > think hostfs would defeat that purpose. > > Well, then we probably don't want to ignore any errors. When do you > have the situation that the drive cannot be resolved? For example, when the next version of Linux decides to rename all devices (it tends to do that often) and suddenly none of them match any device.map entry. The thing is, for what we're trying to do (-t fs, -t fs_uuid, -t partmap) we don't care how will GRUB identify those devices when it's running on the BIOS, so just any string that uniquely identifies them will be enough so we can run our filesystem / partmap probes. > My concern is that introducing a dummy object for non-testing purposes > could indicate bad code quality. It got a bit stuck anyway; see my other mail about -t partmap not working with this method. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)