Re: [PATCH] handle http urls with query string ("?foo") correctly

["David ‘Bombe’ Roden" <bombe@pterodactylus.net>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Thursday 05 June 2008 09:57:39 Junio C Hamano wrote:

> my understanding is that this peculiar http-hosted git repository
> takes:
> 	http://foo.bar.xz/serve.cgi?repo=foo.git/
> as the base URL, and the patch author wants us to ask for (for example)
> "info/alternates" as
> 	http://foo.bar.xz/serve.cgi/info/alternates?repo=foo.git/

Actually the base URL is more like

	http://foo.bar.xz/foo.git/0?type=text/plain

and I want to retrieve objects with

	http://foo.bar.xz/foo.git/0/info/refs?type=text/plain

but the gist is basically the same. My patch will indeed break git for URLs 
like the one you gave.


>  (2) If that is indeed the issue being tackled, sorry, it is not how "dumb
>      protocol" http server is expected to behave.  Your server needs
>      fixing.
> If the protocol being used is still the "dumb commit walker" protocol,
> then, given the base URL of the repository $URL, "info/refs" must exist at
> "$URL/info/refs", and a loose object deadbeef... must exist at
> "$URL/objects/de/adbeef...".  That's how the protocol is defined.

If that is indeed the case, you're right. That could probably be tackled by 
some small fixes in Freenet's http-gateway. I'll talk to the other developers 
about that.


Thanks,

	David

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]