Re: [PATCH] git-add--interactive: manual hunk editing mode

[Thomas Rast <trast@student.ethz.ch>]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

You wrote:
> On Thu, Jun 05, 2008 at 09:53:54AM +0200, Thomas Rast wrote:
> 
> > On the other hand it would be just as powerful.  Manually splitting a
> > hunk is, in the general case, only possible in "my" scheme.  However,
> > to make any difference, you later have to answer 'n' to some of the
> > sub-hunks.  So in "your" scheme, you could just have deleted the lines
> > in question.
> 
> Sorry, I've gotten lost in which is mine and which is yours. Yours is
> the original patch or this patch? Mine is the proposal that spawned this
> patch, or my comments on this patch?

I should have provided a definition, sorry.  By "your" scheme, I meant
the one where one is restricted to deleting existing lines, and thus
deletes '-' lines to disable them; by "my" scheme, where one is free
to edit and changes '-' lines to context to disable them.

At least it's my current understanding that, under the above
definition, "your" scheme is what you actually proposed in
  http://www.spinics.net/lists/git/msg67478.html
  [why doesn't Google find gmane?]
but I misunderstood and implemented "my" scheme.

[Let's just forget about the original patch at the top of the thread;
in retrospect, it _is_ clunky, and the UI didn't get any replies in
favour.]

- Thomas

-- 
Thomas Rast
trast@student.ethz.ch


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]