From: Andrew Morton <akpm@linux-foundation.org>
To: "Thomas Tuttle" <ttuttle@google.com>
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] pagemap: Require reads of /proc/pid/pagemap to be multiples of 8 (v2 of series)
Date: Thu, 5 Jun 2008 12:37:32 -0700 [thread overview]
Message-ID: <20080605123732.98dc47fb.akpm@linux-foundation.org> (raw)
In-Reply-To: <4ca0a85e0806051138q2a6a6aeav941e46c67ee12bd0@mail.gmail.com>
On Thu, 5 Jun 2008 14:38:10 -0400
"Thomas Tuttle" <ttuttle@google.com> wrote:
> This matches the behavior of /proc/kpage{count,flags}, and simplifies
> the logic a bit.
>
> I also changed out and end in struct pagemapread to be u64* instead of
> char*, which makes put_user work the way it was intended. (Before, it
> was only copying the bottom byte of a pagemap entry, because the target
> of the copy was a char*.)
This one is for 2.6.25.x?
Is so, the maintainers are going to wonder why the heck we sent it to
them. It does fix a bug, but it is far from clear what that bug is.
Can we have a better description please?
> Signed-off-by: Thomas Tuttle
Please include <ttuttle@google.com> in the signoffs.
next prev parent reply other threads:[~2008-06-05 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 18:38 [PATCH 1/4] pagemap: Require reads of /proc/pid/pagemap to be multiples of 8 (v2 of series) Thomas Tuttle
2008-06-05 19:37 ` Andrew Morton [this message]
2008-06-05 20:51 ` Matt Mackall
2008-06-05 22:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605123732.98dc47fb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=ttuttle@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.