Re: [RFC/PATCH 2/3] NAND multiple plane feature

["Jörn Engel" <joern@logfs.org>]

On Thu, 5 June 2008 17:58:14 +0100, Alexey Korolev wrote:
> 
> > > -	if (!chip->write_page)
> > > -		chip->write_page = nand_write_page;
> > > -
> > 
> > Why is this removed?
> >
> Oh. May be it would be better to make stand alone patch in order to
> clean up NAND subsystem.

Yes, please. :)

> Using chip->write_page is redundend here. It
> is set once it is set for write procedure only. There is no chip read
> page call like that. IMHO it is better to use static call here. Please
> let me know if you are agree with this. 

Setting it just once is clearly better.  So long as it actually happens
and we don't introduce a bug, I like it.

Jörn

-- 
When I am working on a problem I never think about beauty.  I think
only how to solve the problem.  But when I have finished, if the
solution is not beautiful, I know it is wrong.
-- R. Buckminster Fuller