From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 5/5] qeth: start dev queue after tx drop error
Date: Fri, 06 Jun 2008 12:37:48 +0200 [thread overview]
Message-ID: <20080606103830.766673000@de.ibm.com> (raw)
In-Reply-To: 20080606103743.638691000@de.ibm.com
[-- Attachment #1: 604-qeth-txdrop.diff --]
[-- Type: text/plain, Size: 1306 bytes --]
From: Frank Blaschka <frank.blaschka@de.ibm.com>
In case the xmit function drop out with an error, we have to wake
the netdevice queue to start another xmit.
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/net/qeth_l2_main.c | 1 +
drivers/s390/net/qeth_l3_main.c | 1 +
2 files changed, 2 insertions(+)
diff -urpN linux-2.6/drivers/s390/net/qeth_l2_main.c linux-2.6-patched/drivers/s390/net/qeth_l2_main.c
--- linux-2.6/drivers/s390/net/qeth_l2_main.c 2008-06-06 11:36:26.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/qeth_l2_main.c 2008-06-06 11:36:27.000000000 +0200
@@ -721,6 +721,7 @@ tx_drop:
if ((new_skb != skb) && new_skb)
dev_kfree_skb_any(new_skb);
dev_kfree_skb_any(skb);
+ netif_wake_queue(dev);
return NETDEV_TX_OK;
}
diff -urpN linux-2.6/drivers/s390/net/qeth_l3_main.c linux-2.6-patched/drivers/s390/net/qeth_l3_main.c
--- linux-2.6/drivers/s390/net/qeth_l3_main.c 2008-06-06 11:36:26.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/qeth_l3_main.c 2008-06-06 11:36:27.000000000 +0200
@@ -2764,6 +2764,7 @@ tx_drop:
if ((new_skb != skb) && new_skb)
dev_kfree_skb_any(new_skb);
dev_kfree_skb_any(skb);
+ netif_wake_queue(dev);
return NETDEV_TX_OK;
}
--
next prev parent reply other threads:[~2008-06-06 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 10:37 [patch 0/5] s390: qeth fixes for 2.6.26 frank.blaschka
2008-06-06 10:37 ` [patch 1/5] qeth: layer 3 Oops in ip event handler frank.blaschka
2008-06-06 10:37 ` [patch 2/5] qeth: Use ccw_device_get_id() frank.blaschka
2008-06-06 10:37 ` [patch 3/5] qeth: reduce number of kernel messages frank.blaschka
2008-06-06 10:37 ` [patch 4/5] qeth: Prepare-function to call s390dbf was wrong frank.blaschka
2008-06-06 10:37 ` frank.blaschka [this message]
2008-06-10 22:21 ` [patch 5/5] qeth: start dev queue after tx drop error Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080606103830.766673000@de.ibm.com \
--to=frank.blaschka@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.