From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K4ea2-0002jN-5z for mharc-grub-devel@gnu.org; Fri, 06 Jun 2008 12:14:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K4eZz-0002e0-Cw for grub-devel@gnu.org; Fri, 06 Jun 2008 12:14:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K4eZx-0002Zr-DR for grub-devel@gnu.org; Fri, 06 Jun 2008 12:14:14 -0400 Received: from [199.232.76.173] (port=33447 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K4eZx-0002Zc-6W for grub-devel@gnu.org; Fri, 06 Jun 2008 12:14:13 -0400 Received: from aybabtu.com ([69.60.117.155]:43204) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K4eZw-0002jT-SV for grub-devel@gnu.org; Fri, 06 Jun 2008 12:14:13 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K4eYm-0005nG-Ss for grub-devel@gnu.org; Fri, 06 Jun 2008 18:13:01 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K4eZh-0003cw-IZ for grub-devel@gnu.org; Fri, 06 Jun 2008 18:13:57 +0200 Date: Fri, 6 Jun 2008 18:13:57 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080606161357.GA13885@thorin> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline Content-Transfer-Encoding: 8bit Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [PATCH] _chain can break stuff X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 16:14:16 -0000 --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Turns out that right now, if you try to boot from LVM on ext3 with msdos partmap, you get a core.img that is slightly too big to fit in the post-MBR region. When you're booting from LVM, if it won't fit there you have no other option, which makes this a big problem. If you remove _chain from the list, it fits again. Since _chain can make the difference between core.img fitting or not fitting, I think it should not be included unless user requests it. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.) --XsQoSWH+UP9D9v3l Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="chain.diff" diff -x ChangeLog -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/i386/pc/grub-install.in ./util/i386/pc/grub-install.in --- ../grub2/util/i386/pc/grub-install.in 2008-06-06 17:49:43.000000000 +0200 +++ ./util/i386/pc/grub-install.in 2008-06-06 18:11:28.000000000 +0200 @@ -231,8 +231,8 @@ partmap_module=`$grub_probe --target=par # Device abstraction module, if any (lvm, raid). devabstraction_module=`$grub_probe --target=abstraction --device ${grub_device}` -# _chain is often useful -modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module _chain" +# The order in this list is critical. Be careful when modifiing it. +modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module" $grub_mkimage --output=${grubdir}/core.img --prefix=`make_system_path_relative_to_its_root ${grubdir}`/ $modules || exit 1 --XsQoSWH+UP9D9v3l--