From: Ben Dooks <ben@fluff.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ben Dooks <ben@fluff.org>,
linux-kernel@vger.kernel.org, Pierre Ossman <drzeus@drzeus.cx>,
Harald Welte <laforge@openmoko.org>,
Thomas Kleffel <tk@maintech.de>,
Roman Moravcik <roman.moravcik@gmail.com>
Subject: Re: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <tk@maintech.de>
Date: Sat, 7 Jun 2008 20:50:57 +0100 [thread overview]
Message-ID: <20080607195057.GS11277@trinity.fluff.org> (raw)
In-Reply-To: <20080607121359.50dd7b54.akpm@linux-foundation.org>
On Sat, Jun 07, 2008 at 12:13:59PM -0700, Andrew Morton wrote:
>
> (cc's restored. Please don't remove people)
Sorry, thought I had replied to all.
> On Sat, 7 Jun 2008 13:22:27 +0100 Ben Dooks <ben@fluff.org> wrote:
>
> > > right at the top of the changelog so that the commit is correctly
> > > attributed.
> > >
> > > > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> > >
> > > Please pass these patches through chechpatch? This one alone generates
> > >
> > > total: 40 errors, 29 warnings, 1488 lines checked
> > >
> > > many of which you would have fixed had you been aware of them. That's
> > > what checkpatch is for.
> >
> > Is it ok to fit another patch after this one to fixup these problems?
>
> OK by me, as would be a new patch.
>
> Pierre would be merging this (might have already done so?) - I assume
> he'd prefer a whole new patch.
I'll have to post a new series, the changes to cleanup make the rest of
the series either fuzz, offset or just fail to apply. I'll run the new
series through a test to check that it still works.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2008-06-07 19:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 15:51 [patch 00/15] S3C24XX SD/MMC driver series Ben Dooks
2008-06-06 15:51 ` [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <tk@maintech.de> Ben Dooks
2008-06-07 5:49 ` Andrew Morton
2008-06-07 12:22 ` Ben Dooks
2008-06-07 19:13 ` Andrew Morton
2008-06-07 19:50 ` Ben Dooks [this message]
2008-06-14 16:18 ` Pierre Ossman
2008-06-17 23:02 ` Ben Dooks
2008-06-06 15:51 ` [patch 02/15] MMC: S3C24XX MMC/SD driver write fixes From: Harald Welte <laforge@openmoko.org> Ben Dooks
2008-06-06 15:51 ` [patch 03/15] MMC: DMA free fix for S3C24XX SD/MMC driver From: OpenMoko SVN " Ben Dooks
2008-06-06 15:51 ` [patch 04/15] MMC: S3C24XX MMC/SD stop fix From: Thomas Kleffel <tk@maintech.de> Ben Dooks
2008-06-06 15:51 ` [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfers From: Roman Moracik <roman.moravcik@gmail.com> Ben Dooks
2008-06-14 16:20 ` Pierre Ossman
2008-06-06 15:51 ` [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver Ben Dooks
2008-06-14 16:22 ` Pierre Ossman
2008-06-17 23:20 ` Ben Dooks
2008-06-06 15:51 ` [patch 07/15] MMC: Add support to invert S3C24XX write protect line Ben Dooks
2008-06-06 15:51 ` [patch 08/15] MMC: Ensure host->mrq->data is valid in S3C24XX driver Ben Dooks
2008-06-06 15:51 ` [patch 09/15] MMC: Allow card-detect to be on an non-IRQ capable pin on the S3C24XX Ben Dooks
2008-06-14 16:24 ` Pierre Ossman
2008-06-06 15:51 ` [patch 10/15] MMC: Fix s3c24xx driver s3c2410_dma_request() return code check Ben Dooks
2008-06-06 15:51 ` [patch 11/15] MMC: Fix the retcode in the S3C24XX MMC/SD driver Ben Dooks
2008-06-14 16:25 ` Pierre Ossman
2008-06-17 23:33 ` Ben Dooks
2008-06-06 15:51 ` [patch 12/15] MMC: S3C24XX MMC/SD driver fixes for sg_ access Ben Dooks
2008-06-06 15:51 ` [patch 13/15] MMC: s3cmci: Add MODULE_ALIAS() entries for the platform devices Ben Dooks
2008-06-06 15:51 ` [patch 14/15] MMC: Fix use of msecs where jiffies are needed Ben Dooks
2008-06-06 15:51 ` [patch 15/15] MMC: Add media presence detection to request handling Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607195057.GS11277@trinity.fluff.org \
--to=ben@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=laforge@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.moravcik@gmail.com \
--cc=tk@maintech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.