From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K5Qs2-00044O-Hx for mharc-grub-devel@gnu.org; Sun, 08 Jun 2008 15:48:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5Qs1-00044J-F8 for grub-devel@gnu.org; Sun, 08 Jun 2008 15:48:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5Qs0-000447-2v for grub-devel@gnu.org; Sun, 08 Jun 2008 15:48:04 -0400 Received: from [199.232.76.173] (port=56669 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5Qrz-000444-UJ for grub-devel@gnu.org; Sun, 08 Jun 2008 15:48:03 -0400 Received: from aybabtu.com ([69.60.117.155]:43624) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K5Qrz-0002UN-PZ for grub-devel@gnu.org; Sun, 08 Jun 2008 15:48:04 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K5Qqb-00006x-OB for grub-devel@gnu.org; Sun, 08 Jun 2008 21:46:38 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K5Qri-0000a3-H3 for grub-devel@gnu.org; Sun, 08 Jun 2008 21:47:46 +0200 Date: Sun, 8 Jun 2008 21:47:46 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080608194746.GD21687@thorin> References: <20080604233019.GA21645@thorin> <1212631708.26365.26.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1212631708.26365.26.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] missleading function name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2008 19:48:05 -0000 On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote: > On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote: > > IMHO the name of this function is highly misleading. It makes one think > > it just checks something, but it actually modifies our variables. I think > > "adjust" would fit better than "check". > > But nothing can be better that a good old-fashioned connect before the > function. It looks like it does several things: > > 1) it makes sectors disk relative from partition relative (I guess > that's what grub-emu forgets) > > 2) it normalizes offset to be less than the sector size > > 3) it verifies that the range is inside the partition. Thanks, I made a comment for it based on your description. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)