From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH 1/4] tg3: Fix 5714S / 5715S / 5780S link failures
Date: Mon, 09 Jun 2008 15:42:37 -0700 (PDT) [thread overview]
Message-ID: <20080609.154237.227769010.davem@davemloft.net> (raw)
In-Reply-To: <1213046675.0@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Mon, 9 Jun 2008 11:25:17 -0700
> The git commit ef167e27039eeaea6d3cdd5c547b082e89840bdd entitled
> "Fix supporting flowctrl code" introduced a bug that prevents 5714S,
> 5715S and 5780S devices from falling back to a forced link mode. The
> problem is that the added flow control check will always fail if flow
> control is set to autoneg and either RX or TX (or both) flow control
> is enabled. The driver defaults to setting flow control to autoneg
> and advertises both RX and TX flow control.
>
> The fix is to remove the errant check.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
prev parent reply other threads:[~2008-06-09 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 18:25 [PATCH 1/4] tg3: Fix 5714S / 5715S / 5780S link failures Matt Carlson
2008-06-09 22:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609.154237.227769010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.