From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] TC6393xb update: support system features
Date: Mon, 9 Jun 2008 00:21:23 +0100 [thread overview]
Message-ID: <200806090021.23624.paul@codesourcery.com> (raw)
In-Reply-To: <fb249edb0806081606pb8cdfex82756fac4f70c39f@mail.gmail.com>
On Monday 09 June 2008, andrzej zaborowski wrote:
> Hi,
>
> On 08/06/2008, Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> > Any comments about this? TC6393xb is a multifunctional device as found
> > in tosa or some toshibe e-series PDAs. And this provides some partial
> > emulation of it's features.
>
> Committed, thanks. Perhaps it's good to have at least a short license
> notice
Licence notes and at least basic copyright information should definitely be
required.
> and a note on what the device does or who produces it. I think
> it's not a policy though.
I'd also strongly recommend that these be added. I find it very useful to
have a short comment saying exactly what device we're trying to emulate.
> +/* vim:set shiftwidth=4 ts=4 et: */
We can loose this though.
Paul
prev parent reply other threads:[~2008-06-08 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 18:11 [Qemu-devel] [PATCH] TC6393xb update: support system features Dmitry Baryshkov
2008-06-08 7:20 ` [Qemu-devel] " Dmitry Baryshkov
2008-06-08 23:06 ` andrzej zaborowski
2008-06-08 23:21 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806090021.23624.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.