Re: [Qemu-devel] [PATCH][RESEND] ide: fix ATAPI read drive structure command (v3)

[Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>]

On Sun, Jun 08, 2008 at 08:14:05PM -0600, Alex Williamson wrote:
> Hi,
> 
> Resend of patch from last week.  This has been review by Alexander Graf
> and Anthony Liguori.  The patch fixes diskpart.exe working in Vista when
> a DVD image is loaded.  Please apply to trunk.  Thanks,

Tested it with Linux/OpenSolaris guests and confirmed no obvious regressions
but I haven't traced specifically calls to this function (as used by diskpart
in Vista).

> +            if (format < 0xff && media_is_cd(s)) {
>                  ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST,
> -                                    ASC_INV_FIELD_IN_CMD_PACKET);
> +                                    ASC_INCOMPATIBLE_FORMAT);
> +                break;

couldn't find a reference to this in MMC6's READ DISK STRUCTURE command, why
is format = 0xff allowed if the media is a CD, what about when there is no
media?

Carlo