From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] Char: mxser, ioctl cleanup
Date: Mon, 9 Jun 2008 11:27:42 +0100 [thread overview]
Message-ID: <20080609112742.420ff81b@core> (raw)
In-Reply-To: <1213006112-25965-1-git-send-email-jirislaby@gmail.com>
> case MOXA_GET_MAJOR:
> + printk(KERN_WARNING "mxser: '%s' uses deprecated ioctl %x, fix "
> + "your userspace\n", current->comm, cmd);
Should be rate limited...
Rest looks good, break change is definitely what is needed.
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-06-09 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 10:08 [PATCH] Char: mxser, ioctl cleanup Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, globals cleanup Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, add CP-102UF support Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, update documentation Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, prints cleanup Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, remove predefined isa support Jiri Slaby
2008-06-09 10:08 ` [PATCH] Char: mxser, various cleanups Jiri Slaby
2008-06-09 10:29 ` Alan Cox
2008-06-09 10:27 ` Alan Cox [this message]
2008-06-09 11:43 ` [PATCH v2] Char: mxser, ioctl cleanup Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609112742.420ff81b@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.