From: Ingo Molnar <mingo@elte.hu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] __down_common: use signal_pending_state()
Date: Mon, 9 Jun 2008 15:20:31 +0200 [thread overview]
Message-ID: <20080609132031.GA1737@elte.hu> (raw)
In-Reply-To: <20080604173633.GI3549@parisc-linux.org>
* Matthew Wilcox <matthew@wil.cx> wrote:
> On Wed, Jun 04, 2008 at 09:09:06PM +0400, Oleg Nesterov wrote:
> > Cleanup. __down_common() can use the new signal_pending_state() helper.
>
> This is a bad optimisation. __down_common gets inlined and the
> constant 'state' versions are optimised away for the versions which
> don't apply.
>
> NAK this patch.
well but we had a schedule() bug around this whole topic of
TASK_KILLABLE, so i'd say robustness trumps micro-optimizations. Is this
really a big issue? The dual-ness of TASK_KILLABLE checks is a bit ugly,
and it led to a bug as well.
Ingo
prev parent reply other threads:[~2008-06-09 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 17:09 [PATCH 2/2] __down_common: use signal_pending_state() Oleg Nesterov
2008-06-04 17:36 ` Matthew Wilcox
2008-06-04 18:08 ` Oleg Nesterov
2008-06-04 19:54 ` Matthew Wilcox
2008-06-09 13:20 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609132031.GA1737@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.